Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed Promise Polyfill to reduce bundle size #417

Merged
merged 14 commits into from
Mar 9, 2020

Conversation

zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Feb 26, 2020

Summary

Removed Promise Polyfill from browser entry point to reduce bundle size. A user can still use the SDK in older browsers by including the promise polyfill themselves.

Test plan

All tests pass by providing promise polyfill as part of the test setup.

@coveralls
Copy link

coveralls commented Feb 26, 2020

Coverage Status

Coverage decreased (-0.0003%) to 97.222% when pulling 4ad521b on zeeshan/remove-promise-polyfill into 5cf5ddc on master.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove the promise-polyfill library from our dependencies or at least move it to dev-dependencies since we use it for testing: https://github.com/optimizely/javascript-sdk/blob/master/packages/optimizely-sdk/package.json#L43

@zashraf1985
Copy link
Contributor Author

I think we need to remove the promise-polyfill library from our dependencies or at least move it to dev-dependencies since we use it for testing: https://github.com/optimizely/javascript-sdk/blob/master/packages/optimizely-sdk/package.json#L43

Yes you are right. This should have been moved to dev dependencies. This is done now.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 merged commit 1e00509 into master Mar 9, 2020
@mjc1283 mjc1283 deleted the zeeshan/remove-promise-polyfill branch March 9, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants