-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Removed Promise Polyfill to reduce bundle size #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to remove the promise-polyfill
library from our dependencies or at least move it to dev-dependencies
since we use it for testing: https://github.com/optimizely/javascript-sdk/blob/master/packages/optimizely-sdk/package.json#L43
Yes you are right. This should have been moved to dev dependencies. This is done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
Removed Promise Polyfill from browser entry point to reduce bundle size. A user can still use the SDK in older browsers by including the promise polyfill themselves.
Test plan
All tests pass by providing promise polyfill as part of the test setup.