Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with batch execution of queries not considering filters #233

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

wvandeun
Copy link
Contributor

Depends on #232

There's an issue when using the parallel execution of queries.
In the current implementation we don't consider the filters that were passed into the query.
This could lead to the client making excessive and unneeded GraphQL queries.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop     #233   +/-   ##
========================================
  Coverage    69.43%   69.43%           
========================================
  Files           83       83           
  Lines         7548     7548           
  Branches      1394     1394           
========================================
  Hits          5241     5241           
  Misses        1932     1932           
  Partials       375      375           
Flag Coverage Δ
integration-tests 22.20% <0.00%> (ø)
python-3.10 44.91% <100.00%> (ø)
python-3.11 44.91% <100.00%> (ø)
python-3.12 44.91% <100.00%> (ø)
python-3.13 44.91% <100.00%> (ø)
python-3.9 44.91% <100.00%> (ø)
python-filler-3.12 23.80% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/client.py 66.97% <100.00%> (ø)

@wvandeun wvandeun force-pushed the wvd-20240110-fix-issue-parallel-query branch from 6eb5d46 to bb9f47e Compare January 10, 2025 16:23
@wvandeun wvandeun force-pushed the wvd-20240110-fix-issue-parallel-query branch from bb9f47e to 4947c70 Compare January 13, 2025 13:07
@wvandeun wvandeun merged commit e47a240 into develop Jan 13, 2025
14 checks passed
@wvandeun wvandeun deleted the wvd-20240110-fix-issue-parallel-query branch January 13, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants