Add possibility to use filters in the SDK client's count method #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvandeun
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #232 +/- ##
========================================
Coverage 68.70% 68.71%
========================================
Files 82 82
Lines 7525 7527 +2
Branches 1392 1392
========================================
+ Hits 5170 5172 +2
Misses 1981 1981
Partials 374 374
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gmazoyer
approved these changes
Jan 10, 2025
dgarros
approved these changes
Jan 10, 2025
| @@ -83,6 +83,16 @@ async def test_method_count(clients, mock_query_repository_count, client_type): | |||
| assert count == 5 | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("client_type", client_types) | |||
There was a problem hiding this comment.
Not sure if this test is really checking anything since the payload is static
ideally we should add an integration tests for it
dgarros
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.