Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default opm index image for run bundle(-upgrade) #5171

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

joelanford
Copy link
Member

Signed-off-by: Joe Lanford [email protected]

Description of the change:
Update default base image used in run bundle and run bundle-upgrade to the multi-arch quay.io/operator-framework/opm:latest image.

Motivation for the change:
To support non-amd64 clusters and to avoid using the latest master build of opm (which is what quay.io/operator-framework/upstream-opm-builder:latest points to). The quay.io/operator-framework/opm:latest image is the latest tagged release of opm

See also: operator-framework/operator-registry#762

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@joelanford
Copy link
Member Author

/hold

The shell in the new image is at a different location. I think we may need to symlink /busybox/sh to /bin/sh in the new image.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2021
@joelanford
Copy link
Member Author

/hold cancel

Removed the hardcoded executable paths in the entrypoint script we run. Now it relies on whatever PATH is configured in the image, which works for both quay.io/operator-framework/upstream-opm-builder and quay.io/operator-framework/opm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2021
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems ok for me.
It was using the latest tag before.
However, it maybe would be nice in the future we start to work with OPM tags as well.
Otherwise, it might begin to fail because of some change that was not tested.

/lgtm

Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@jmrodri
Copy link
Member

jmrodri commented Sep 3, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@asmacdo asmacdo merged commit 4ae3033 into operator-framework:master Sep 20, 2021
@asmacdo asmacdo added this to the v1.13.0 milestone Sep 29, 2021
@joelanford joelanford deleted the default-opm-image branch August 30, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants