-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update default opm index image for run bundle(-upgrade) #5171
update default opm index image for run bundle(-upgrade) #5171
Conversation
c241797
to
be47bbf
Compare
/hold The shell in the new image is at a different location. I think we may need to symlink |
be47bbf
to
7f4c853
Compare
/hold cancel Removed the hardcoded executable paths in the entrypoint script we run. Now it relies on whatever PATH is configured in the image, which works for both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems ok for me.
It was using the latest tag before.
However, it maybe would be nice in the future we start to work with OPM tags as well.
Otherwise, it might begin to fail because of some change that was not tested.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion.
/lgtm
7f4c853
to
19bd7c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Joe Lanford <[email protected]>
19bd7c4
to
814ebe1
Compare
/lgtm |
Signed-off-by: Joe Lanford [email protected]
Description of the change:
Update default base image used in
run bundle
andrun bundle-upgrade
to the multi-archquay.io/operator-framework/opm:latest
image.Motivation for the change:
To support non-amd64 clusters and to avoid using the latest
master
build ofopm
(which is whatquay.io/operator-framework/upstream-opm-builder:latest
points to). Thequay.io/operator-framework/opm:latest
image is the latest tagged release ofopm
See also: operator-framework/operator-registry#762
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs