update default scaffolded opm base image #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
- Change default base image scaffolded during `opm index` and `opm alpha generate dockerfile` to `quay.io/operator-framework/opm:latest` - update opm-example.Dockerfile to reflect this change (and to focus on file-based configs rather than sqlite databases) Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
default-opm-image
branch
from
555a205 to
07c8880
Compare
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
==========================================
+ Coverage 50.29% 50.41% +0.11%
==========================================
Files 101 101
Lines 8699 8720 +21
==========================================
+ Hits 4375 4396 +21
Misses 3471 3471
Partials 853 853
Continue to review full report at Codecov.
|
This was referenced Aug 25, 2021
5 tasks
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe Lanford [email protected]
Description of the change:
opm indexandopm alpha generate dockerfiletoquay.io/operator-framework/opm:latestfile-based configs rather than sqlite databases)
Motivation for the change:
The new upstream base image for
opmis multi-arch,:latestpoints to a tagged release (instead of master), and the image build is tested on every PR from github actions, making image build failures during tag pushes less likely.See also: operator-framework/operator-sdk#5171
Reviewer Checklist
/docs