-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.10] ddns-scripts: backport updates to 24.10 branch #26033
Merged
feckert
merged 12 commits into
openwrt:openwrt-24.10
from
dmsza:openwrt-24.10-update-ddns
Feb 24, 2025
Merged
[24.10] ddns-scripts: backport updates to 24.10 branch #26033
feckert
merged 12 commits into
openwrt:openwrt-24.10
from
dmsza:openwrt-24.10-update-ddns
Feb 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing endpoint can handle IPv6 addresses as well. (cherry picked from commit ce4b32e)
Adds ipv64.net service as DDNS provider Docs: https://ipv64.net/dyndns_updater_api Signed-off-by: Hui Zhui <[email protected]> (cherry picked from commit da4e270)
Signed-off-by: FriesI23 Qin <[email protected]> (cherry picked from commit c1f247d)
Using the PUT method recreates the DNS record with and only with the newly provided data. This seems unnecessary. In particular, we don't need to hardcode a TTL of 120. Any existing comment would be lost too. The only detail we need to change is the IP address. Leave everything else as it was. Signed-off-by: Gedalya Nie <[email protected]> (cherry picked from commit 0a98b6d)
Fix signature expiration issue during retries. Signed-off-by: FriesI23 Qin <[email protected]> (cherry picked from commit 9d5da21)
Migrate retry_count to retry_max_count in the script to fix infinite retry loop. Signed-off-by: FriesI23 Qin <[email protected]> (cherry picked from commit 0dceb9d)
If pppoe is used for wan access. script set 'eth1' as interface for curl call. The correct interface is however 'pppoe-wan'. These scripts use 'network_get_physdev' function to get real device for bind_network but this is wrong. We need instead the l3_device of the the logical interface. In case if we don't use pppoe connection - 'l3_device' is equal to real device. Follow P/R: openwrt#14431 Signed-off-by: Coia Prant <[email protected]> (cherry picked from commit 9cd00fb)
DigitalOcean API requires a "type" JSON field to update a DNS record. This adds that while checking for IPv6 to change which record type to use. Without it, the API call fails, making the script unable to update the DNS records for DigitalOcean. Signed-off-by: Adam Beck <[email protected]> (cherry picked from commit 1302e50)
(cherry picked from commit 1c1125a)
Signed-off-by: FriesI23 Qin <[email protected]> (cherry picked from commit f02a1df)
Signed-off-by: Bei Lin <[email protected]> (cherry picked from commit 0a2746c)
Prevents IPv6 updates to also update IPv4 (undesirable when behind a CGNAT) Signed-off-by: Dimitri Souza <[email protected]> (cherry picked from commit 65cbccf)
LGTM
|
Thanks merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @feckert
Compile tested: NanoPI R6S, OpenWrt 24.10.0
Run tested: NanoPI R6S, OpenWrt 24.10.0.
Description: backport/chery pick latest ddns-scripts commits to 24.10 branch
Test environment (24.10.0 updated with 24.10 packages built with this PR):