Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.10] ddns-scripts: backport updates to 24.10 branch #26033

Merged
merged 12 commits into from
Feb 24, 2025

Conversation

dmsza
Copy link
Contributor

@dmsza dmsza commented Feb 21, 2025

Maintainer: @feckert
Compile tested: NanoPI R6S, OpenWrt 24.10.0
Run tested: NanoPI R6S, OpenWrt 24.10.0.
Description: backport/chery pick latest ddns-scripts commits to 24.10 branch

Test environment (24.10.0 updated with 24.10 packages built with this PR):

 -----------------------------------------------------
 OpenWrt 24.10.0, r28427-6df0e3d02a
 -----------------------------------------------------
root@router:~# opkg list-installed | grep ddns
ddns-scripts - 2.8.2-r64
ddns-scripts-services - 2.8.2-r64
luci-app-ddns - 25.049.66344~2b8e93c

benjaminfrank and others added 12 commits February 21, 2025 10:43
The existing endpoint can handle IPv6 addresses as well.

(cherry picked from commit ce4b32e)
Adds ipv64.net service as DDNS provider

Docs: https://ipv64.net/dyndns_updater_api
Signed-off-by: Hui Zhui <[email protected]>
(cherry picked from commit da4e270)
Signed-off-by: FriesI23 Qin <[email protected]>
(cherry picked from commit c1f247d)
Using the PUT method recreates the DNS record with and only with
the newly provided data. This seems unnecessary. In particular,
we don't need to hardcode a TTL of 120. Any existing comment
would be lost too.

The only detail we need to change is the IP address. Leave everything
else as it was.

Signed-off-by: Gedalya Nie <[email protected]>
(cherry picked from commit 0a98b6d)
Fix signature expiration issue during retries.

Signed-off-by: FriesI23 Qin <[email protected]>
(cherry picked from commit 9d5da21)
Migrate retry_count to retry_max_count in the script to fix infinite retry loop.

Signed-off-by: FriesI23 Qin <[email protected]>
(cherry picked from commit 0dceb9d)
If pppoe is used for wan access. script set 'eth1' as interface for curl
call. The correct interface is however 'pppoe-wan'.

These scripts use 'network_get_physdev' function to get real device for
bind_network but this is wrong. We need instead the l3_device of the the
logical interface.

In case if we don't use pppoe connection - 'l3_device' is equal to real device.

Follow P/R:
 openwrt#14431

Signed-off-by: Coia Prant <[email protected]>
(cherry picked from commit 9cd00fb)
DigitalOcean API requires a "type" JSON field to update a DNS
record. This adds that while checking for IPv6 to change which
record type to use. Without it, the API call fails, making
the script unable to update the DNS records for DigitalOcean.

Signed-off-by: Adam Beck <[email protected]>
(cherry picked from commit 1302e50)
(cherry picked from commit 1c1125a)
Signed-off-by: FriesI23 Qin <[email protected]>
(cherry picked from commit f02a1df)
Prevents IPv6 updates to also update IPv4 (undesirable when behind a CGNAT)

Signed-off-by: Dimitri Souza <[email protected]>
(cherry picked from commit 65cbccf)
@dmsza
Copy link
Contributor Author

dmsza commented Feb 21, 2025

Two commits part of this PR and done by other authors (029f131 and 8462b1a) are failing test formalities, but they have been already accepted and merged into main (1c1125a and ce4b32e respectively). This PR is only chery picking/backporing latest ddns-scripts updates from main into openwrt-24.10.

@feckert
Copy link
Member

feckert commented Feb 21, 2025

LGTM

  • The Test Build issues are not related to this change, because this are only script changes. And other Test Build succceeded
  • The Test Formalities is failing on two comits because the Signed-of-by does no match with the commiter! This slipped through my fingers during master merge. But is fine to beackported to the stable branch.

@dmsza dmsza changed the title ddns-scripts: backport updates to 24.10 branch [24.10] ddns-scripts: backport updates to 24.10 branch Feb 22, 2025
@feckert feckert merged commit bc4779c into openwrt:openwrt-24.10 Feb 24, 2025
12 of 18 checks passed
@feckert
Copy link
Member

feckert commented Feb 24, 2025

Thanks merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants