ddns-scripts: Get 'l3 device' (for pppoe connection) for bind_network using curl

[welderpb]

Maintainer: none
Compile tested: mips_24kc
Run tested: mips_24kc, REVISION 'r15449-936220186d'

Description:
ddns is not working for ipv4, if pppoe is used for wan access. script set 'eth1'
as interface for curl in my case. The correct interface is 'pppoe-wan'.
script uses 'network_get_physdev' function to get real device for bind_network.. So this pull request change function to 'network_get_device'. In case if we don't use pppoe connection - 'l3 device' is equal to real device.
in my case:
root@OpenWrt:~# ifstatus wan
{
"up": true,
"pending": false,
"available": true,
"autostart": true,
"dynamic": false,
"uptime": 8914,
"l3_device": "pppoe-wan",
"proto": "pppoe",
"device": "eth1",
......

Signed-off-by: Pavel Bukhatkin [email protected]

[jow-]

You should adjust the error log message as well, it still mentions network_get_physdev

[welderpb]

provider ydns.io
ddns config:

        option enabled '1'
        option domain 'xxx.ydns.eu'
        option username 'kY6yVgVwddlWWXUZDX'
        option password 'ZZZZZZZZZZXXXXXXXXXYYYYYYYY'
        option interface 'wan'
        option ip_source 'network'
        option ip_network 'wan'
        option use_https '1'
        option update_url 'https://[USERNAME]:[PASSWORD]@ydns.io/api/v1/update/?host=[DOMAIN]&ip=[IP]'
        option lookup_host 'xxx.ydns.eu'

wan config:

	option ifname 'eth1'
	option _orig_ifname 'eth1'
	option _orig_bridge 'false'
	option proto 'pppoe'
	option username 'xxxyyyzzz'
	option password '123'

default behavior with curl:
145335 : Local IP 'xx.161.121.166' detected on network 'wan'
145335 : Update needed - L: 'xx.161.121.166' <> R: 'xx.161.121.161'
145336 : Force communication via device 'eth1'
145336 : #> /usr/bin/curl -RsS -o /var/run/ddns/ydns.dat --stderr /var/run/ddns/ydns.err --interface eth1 --noproxy '*' 'https://kY6yVgVwddlWWXUZDX:***PW***@ydns.io
/api/v1/update/?host=xxx.ydns.eu&ip=xx.161.121.166'
145545 ERROR : cURL Error: '28'
145545 : curl: (28) Failed to connect to ydns.io port 443: Operation timed out

when PR is applied:
145752 : Update needed - L: 'xx.161.121.166' <> R: 'xx.161.121.161'
145752 : Force communication via device 'pppoe-wan'
145752 : #> /usr/bin/curl -RsS -o /var/run/ddns/ydns.dat --stderr /var/run/ddns/ydns.err --interface pppoe-wan --noproxy '*' 'https://kY6yVgVwddlWWXUZDX:***PW***@yd
ns.io/api/v1/update/?host=xxx.ydns.eu&ip=xx.161.121.166'
145753 : DDNS Provider answered:
ok

So, we can see curl is used right interface pppoe-wan as bind interface with patch applied.

[feckert]

@welderpb thanks for reporting and staging this pullrequest. I have pushed this to master with 036079b and changed also the logging message as requested.