Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "if" statement for loop unrolling in rms kernel. #27215

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Add "if" statement for loop unrolling in rms kernel. #27215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d4f21b
Add "if" statement for loop unrolling in rms kernel.
mangguo321 Oct 24, 2024
6e5741c
Add test case
mangguo321 Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions src/plugins/intel_cpu/src/nodes/kernels/x64/rms_kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,22 +123,25 @@ void jit_rms_kernel<isa>::generate() {
// x * 1/Sqrt(ReduceMean(x^2,axes)+eps) * gamma
// sum(x^2)
align(16);
Xbyak::Label loop_4reg;
L(loop_4reg);
{
load(vmm_src, reg_src, m_jcp.src_prc, vec_size, false);
vfmadd231ps(vmm_sum0, vmm_src, vmm_src);
load(vmm_src, reg_src, m_jcp.src_prc, vec_size, false, vec_size * m_jcp.src_prc.size() * 1);
vfmadd231ps(vmm_sum1, vmm_src, vmm_src);
load(vmm_src, reg_src, m_jcp.src_prc, vec_size, false, vec_size * m_jcp.src_prc.size() * 2);
vfmadd231ps(vmm_sum2, vmm_src, vmm_src);
load(vmm_src, reg_src, m_jcp.src_prc, vec_size, false, vec_size * m_jcp.src_prc.size() * 3);
vfmadd231ps(vmm_sum3, vmm_src, vmm_src);

add(reg_src, vec_size * m_jcp.src_prc.size() * 4);
dec(reg_size);
jnz(loop_4reg);
if ((m_jcp.data_size / (vec_size * 4)) != 0) {
Xbyak::Label loop_4reg;
L(loop_4reg);
{
load(vmm_src, reg_src, m_jcp.src_prc, vec_size, false);
vfmadd231ps(vmm_sum0, vmm_src, vmm_src);
load(vmm_src, reg_src, m_jcp.src_prc, vec_size, false, vec_size * m_jcp.src_prc.size() * 1);
vfmadd231ps(vmm_sum1, vmm_src, vmm_src);
load(vmm_src, reg_src, m_jcp.src_prc, vec_size, false, vec_size * m_jcp.src_prc.size() * 2);
vfmadd231ps(vmm_sum2, vmm_src, vmm_src);
load(vmm_src, reg_src, m_jcp.src_prc, vec_size, false, vec_size * m_jcp.src_prc.size() * 3);
vfmadd231ps(vmm_sum3, vmm_src, vmm_src);

add(reg_src, vec_size * m_jcp.src_prc.size() * 4);
dec(reg_size);
jnz(loop_4reg);
}
}

// 1 ~ 3 vmm
for (size_t i = m_jcp.data_size / (vec_size * 4) * 4; i < m_jcp.data_size / vec_size; i++) {
load(vmm_src, reg_src, m_jcp.src_prc, vec_size, false);
Expand Down
11 changes: 11 additions & 0 deletions src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/instances/x64/rms_norm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,17 @@ const std::vector<std::vector<InputShape>> shapes{
{ov::Shape{1024 + 16 + 1}, ov::Shape{1024 + 16 + 1}}}
},
},
// small data size
{
// data shape
{ov::test::InputShape{ov::PartialShape{-1, -1, 31},
{ov::Shape{1, 8, 31}, ov::Shape{2, 3, 31}}}
},
// scale shape
{ov::test::InputShape{ov::PartialShape{31},
{ov::Shape{31}, ov::Shape{31}}}
},
},
// scale is scalar
{
// data shape
Expand Down
Loading