Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "if" statement for loop unrolling in rms kernel. #27215

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

mangguo321
Copy link
Contributor

Details:

  • Add "if" statement for loop unrolling in rms kernel to fix Segmentation Fault in tiny-random-sd3 model

Tickets:

@mangguo321 mangguo321 requested review from a team as code owners October 24, 2024 06:06
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Oct 24, 2024
@mangguo321 mangguo321 requested review from luo-cheng2021 and removed request for a team October 24, 2024 06:08
Copy link
Contributor

@luo-cheng2021 luo-cheng2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dmitry-gorokhov dmitry-gorokhov added this to the 2024.5 milestone Oct 24, 2024
@dmitry-gorokhov dmitry-gorokhov self-assigned this Oct 24, 2024
@dmitry-gorokhov
Copy link
Contributor

@mangguo321 Could you please extend RMS test to cover such issue?

@mangguo321
Copy link
Contributor Author

@dmitry-gorokhov Test case extended.

@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Oct 28, 2024
Merged via the queue into openvinotoolkit:master with commit 78864ca Oct 28, 2024
155 checks passed
CuriousPanCake pushed a commit to CuriousPanCake/openvino that referenced this pull request Nov 6, 2024
…#27215)

### Details:
- *Add "if" statement for loop unrolling in rms kernel to fix
Segmentation Fault in tiny-random-sd3 model*

### Tickets:
 - *CVS-152057*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin Code Freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants