Field trip fixes July 30 #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this does not resolve entirely ibi-group/trimet-mod-otp#302 (a backend change is also needed), but it does DRY things out a bit and make things a bit easier to follow re ibi-group/trimet-mod-otp#302
binh-dam-ibigroup
approved these changes
Aug 4, 2021
|
Thanks @binh-dam-ibigroup. Comments addressed in a99744f |
evansiroky
approved these changes
Aug 4, 2021
|
@binh-dam-ibigroup I changed it to |
|
🎉 This PR is included in version 3.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a couple of field trip items:
It also fixes a css issue with display of date time options in Firefox by using flex (rendering is also improved with Chrome)