Update trip status on request on delete #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansiroky
reviewed
Aug 4, 2021
app/controllers/FieldTrip.java
Outdated
Comment on lines
552
to
555
|
|
||
| System.out.println(requestId); | ||
| System.out.println(numStudents); | ||
| System.out.println(numChaperones); | ||
| System.out.println(numFreeStudents); |
There was a problem hiding this comment.
Deleted in dbf308c.
evansiroky
reviewed
Aug 4, 2021
app/controllers/FieldTrip.java
Outdated
| /** | ||
| * Gson exclusion strategy designed to skip fields that could contribute to an overly large JSON response. | ||
| */ | ||
| private static final ExclusionStrategy FIELD_TRIP_EXCLUSION_STRATEGY = new ExclusionStrategy() { |
There was a problem hiding this comment.
This variable probably doesn't need to be in SCREAMING_SNAKE_CASE.
There was a problem hiding this comment.
Changed case in dbf308c.
evansiroky
approved these changes
Aug 4, 2021
|
@evansiroky would you be able to assign this to @binh-dam-ibigroup? He and Miles may also need to be added to this repo. |
|
Just assigned to @binh-dam-ibigroup for final review at the request of @landonreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ibi-group/trimet-mod-otp#302. Because the status field was not being updated on delete, the trip status icon was showing a "check" even after deleting the trip.