Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Controller runtime update" #150

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

gibizer
Copy link
Collaborator

@gibizer gibizer commented Feb 14, 2024

Reverts #144

There is no ubi9/go-toolset:1.21 available and won't be until May. So we can only move to controller-runtime 0.16 and golang 1.20.

@openshift-ci openshift-ci bot requested review from olliewalsh and viroel February 14, 2024 09:49
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gibizer gibizer requested a review from bshephar February 14, 2024 09:50
@gibizer
Copy link
Collaborator Author

gibizer commented Feb 14, 2024

We are going back to a known good state with this revert so I'm merging it without waiting for CI

@gibizer gibizer merged commit a9ce3ab into main Feb 14, 2024
4 of 9 checks passed
@gibizer gibizer deleted the revert-144-controller-runtime branch July 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant