Controller runtime update #144
Conversation
|
To be able to some level of local testing we need a bump proposal in mariadb-operator. |
|
/hold waiting for the go decision to merge these bump across the operators at the same time. |
|
Envtest is crashing with the new dependencies probably due to mariadb changes #145 (comment) |
|
After a rebase of this locally and using replace lines to the latest controller runtime bumps from the other operators and lib common the functional test passed for me locally. |
Signed-off-by: Brendan Shephard <[email protected]>
This change updates the webhook functions to comply with the new standard for controller-runtime. Signed-off-by: Brendan Shephard <[email protected]>
This change updates the manager intialisation to comply with the new controller-runtime schema. Signed-off-by: Brendan Shephard <[email protected]>
This change fixes the Watches declarations to comply with the new controller-runtime standards Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
controller-runtime
branch
from
bd31c03 to
641c8c1
Compare
|
@bshephar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, gibizer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This changes updates the controller-runtime and fixes the initialisation of objects to comply with the new controller-runtime standards. Namely:
We fix the function signatures of the webhook to include admissions.Warnings:
kubernetes-sigs/controller-runtime@8770b4d
We fix the initialisation of the manager to declare the webhook following the new schema:
kubernetes-sigs/controller-runtime@91cdd8c
We fix the Watches function to comply with the new signature definition:
kubernetes-sigs/controller-runtime@dc62ed5
Add context to EventHandlers:
kubernetes-sigs/controller-runtime@2464a9d