Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KubeVirt/NMO] Remove obselete jobs configuration and change cluster profile #44153

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

orenc1
Copy link
Contributor

@orenc1 orenc1 commented Oct 10, 2023

The last supported CNV version that includes NMO is 4.11, and it is built from master branch of https://github.com/kubevirt/node-maintenance-operator.git. Removing all lanes besides that.
Updating the OCP used to 4.11.
Changing the cluster_profile used to aws-virtualization, so CI on that repo will be charged by CNV cost center, not openshift.

@openshift-ci openshift-ci bot requested review from mshitrit and razo7 October 10, 2023 11:08
@slintes
Copy link
Member

slintes commented Oct 10, 2023

/assign
/lgtm
/approve

/pj-rehearse auto-ack

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 10, 2023
…profile

The last supported CNV version that includes NMO is 4.11, and it is built from master branch of https://github.com/kubevirt/node-maintenance-operator.git.
Removing all lanes besides that.
Updating the OCP used to 4.11.
Changing the cluster_profile used to aws-virtualization, so CI on that repo will be charged by CNV cost center, not openshift.

Signed-off-by: Oren Cohen <[email protected]>
@orenc1 orenc1 force-pushed the refresh_kubevirt_nmo branch from 48e233f to c390d3a Compare October 10, 2023 12:59
@orenc1
Copy link
Contributor Author

orenc1 commented Oct 10, 2023

/pj-rehearse auto-ack

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@orenc1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-kubevirt-node-maintenance-operator-master-openshift-e2e kubevirt/node-maintenance-operator presubmit Presubmit changed
pull-ci-kubevirt-node-maintenance-operator-master-ci-index kubevirt/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-kubevirt-node-maintenance-operator-master-images kubevirt/node-maintenance-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@orenc1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/kubevirt/node-maintenance-operator/master/openshift-e2e c390d3a link unknown /pj-rehearse pull-ci-kubevirt-node-maintenance-operator-master-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@slintes
Copy link
Member

slintes commented Oct 10, 2023

Oh, the e2e error is a known issue actually, caused by a change in OCP 4.11, which we fixed a while ago in the medik8s/nmo repo: medik8s/node-maintenance-operator#27

@orenc1 Does it need to be ported to kubevirt/nmo?
The issue is that currently on OCP 4.11 it's not prevented to put multiple control plane nodes into maintenance.

The CI config is ok though.

/pj-rehearse ack
/lgtm

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 10, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit b95fb34 into openshift:master Oct 10, 2023
@orenc1 orenc1 deleted the refresh_kubevirt_nmo branch October 10, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants