Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken functionality - etcd-quorum-guard new name in OCP 4.11 #27

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Apr 27, 2022

We use webhook for checking the etcd-quorum-guard and ensuring that we don't put master nodes into maintenance mode which could interfere with the quorum of etcd between working masters.
Lately, after updating to OCP 4.11 in our CI, we have got errors in our e2e tests regarding that and apparently it is because the code have been checking the etcd-quorum-guard with the old name (etcd-quorum-guard) and not with the new one etcd-guard-pdb.

@openshift-ci openshift-ci bot requested review from beekhof and slintes April 27, 2022 15:23
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 changed the title Update Etcd Quorum PDB Name from etcd-quorum-guarde to etcd-guard-pdb Fix e2e test - etcd-quorum-guard new name Apr 27, 2022
@slintes
Copy link
Member

slintes commented Apr 27, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2ed9dfd into medik8s:main Apr 27, 2022
@slintes
Copy link
Member

slintes commented Apr 27, 2022

please do not cherry pick to release-12, it breaks OCP 4.10!
and btw, the title is misleading. Motivation isn't to fix the test, but the broken functionality

@razo7 razo7 mentioned this pull request Apr 28, 2022
@razo7 razo7 changed the title Fix e2e test - etcd-quorum-guard new name Fix broken functionality - etcd-quorum-guard new name in OCP 4.11 Apr 28, 2022
@slintes
Copy link
Member

slintes commented Apr 28, 2022

this will break release 0.12, but fixed by #29 afterwards

/cherrypick release-0.12

@openshift-cherrypick-robot

@slintes: new pull request created: #30

In response to this:

this will break release 0.12, but fixed by #29 afterwards

/cherrypick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants