Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cri-o job and config to config-updater #4082

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Add cri-o job and config to config-updater #4082

merged 1 commit into from
Jun 18, 2019

Conversation

umohnani8
Copy link
Contributor

Update the config-updater to include the cri-o jobs
and config regex so that they can be automatically uploaded
to the cluster.

Signed-off-by: Urvashi Mohnani [email protected]

@umohnani8
Add cri-o job and config to config-updater
8bf02d2 
Update the config-updater to include the cri-o jobs
and config regex so that they can be automatically uploaded
to the cluster.

Signed-off-by: Urvashi Mohnani <[email protected]>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2019
@umohnani8 umohnani8 mentioned this pull request Jun 18, 2019
Merged
@umohnani8
Copy link
Contributor Author

@petr-muller @smarterclayton PTAL

petr-muller
petr-muller approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit 039a8f1 into openshift:master Jun 18, 2019
@openshift-ci-robot
Copy link
Contributor

@umohnani8: Updated the plugins configmap in namespace ci using the following files:

  • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml

In response to this:

Update the config-updater to include the cri-o jobs
and config regex so that they can be automatically uploaded
to the cluster.

Signed-off-by: Urvashi Mohnani [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@petr-muller petr-muller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umohnani8 @openshift-ci-robot @petr-muller @openshift-merge-robot