Add ci-operator config and job for cri-o #3962
Conversation
openshift-ci-robot
added
the
size/L
|
@mrunalp @smarterclayton PTAL |
ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-release-1.13-postsubmits.yaml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,42 @@ | |||
| postsubmits: | |||
There was a problem hiding this comment.
You shouldn't need this, remove the promotion config from your job (remove promotion:) and then regen and it should go away.
There was a problem hiding this comment.
I removed promotion: from the config yaml and regenerated, but the postsubmits did not go away.
There was a problem hiding this comment.
delete the new files under ci-operator/jobs/* that got created, then run regenerate
There was a problem hiding this comment.
got it, thanks! done
| openshift_installer: | ||
| cluster_profile: aws | ||
| upgrade: false | ||
| - as: launch-aws |
There was a problem hiding this comment.
you'll need to make this an optional job (after generating) by adding the correct "optional" attributes in presubmits.yaml. See what origin launch-aws does. (required: false, optional: true, I think)
|
Waiting cri-o/cri-o#2449 to get in for the rehearse tests here to pass |
|
/retest |
|
/test pj-rehearse |
| @@ -0,0 +1,64 @@ | |||
| base_images: | |||
| base: | |||
| name: "4.1" | |||
There was a problem hiding this comment.
This is for cri-o 1.13, so that should be for 4.1. cri-o 1.14 will be for 4.2.
|
@smarterclayton the e2e-aws test suite is failing on 2 prometheus tests https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_release/3962/rehearse-3962-pull-ci-cri-o-cri-o-release-1.13-e2e-aws/7. |
|
@stevekunetsov ouch, the |
|
@adambkaplan do you know why these would fail? |
|
@smarterclayton no idea - that method is shared between the normal prometheus tests and the build metrics test. @brancz can you shed some light here? |
|
The failure is that there is an alert firing, that shouldn't be firing, and missing the crio job. The discovery for crio is configured here: https://github.com/openshift/cluster-monitoring-operator/blob/5092b55844dfec03d61f0c767f01da887e95f40c/assets/prometheus-k8s/service-monitor-kubelet.yaml#L32-L48 I'm downloading the Prometheus dump to understand more. |
|
Yep looks like it's not a discovery problem, but it really can't be scraped for some reason, so the failed CI is legit:
|
|
/test pj-rehearse |
3 similar comments
|
/test pj-rehearse |
|
/test pj-rehearse |
|
/test pj-rehearse |
Add yaml files to config and jobs for cri-o release-1.13 branch so that we can trigger the e2e-aws tests on cri-o PRs. Signed-off-by: Urvashi Mohnani <[email protected]>
|
Tests are green! The sharded-config test error is saying @smarterclayton what do I need to do to make this pass? |
@umohnani8 Some of your config files are not covered by the config-updater config here, meaning they wouldn't be automatically uploaded to the cluster. You need to add regexes covering your configs there, for both
Important: The config-updater config change needs to be merged in a separate PR first |
|
@petr-muller got it, thanks! Opened #4082 for the config-updater. |
|
/test correctly-sharded-config |
|
@petr-muller all tests are green now :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@umohnani8: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add yaml files to config and jobs for cri-o release-1.13
branch so that we can trigger the e2e-aws tests on cri-o
PRs.
Signed-off-by: Urvashi Mohnani [email protected]