-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp-pd-csi-driver: disable auto run of sanity tests #36246
gcp-pd-csi-driver: disable auto run of sanity tests #36246
Conversation
@RomanBednar: the
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
493187f
to
88e9c31
Compare
@@ -39,7 +39,8 @@ resources: | |||
cpu: 100m | |||
memory: 200Mi | |||
tests: | |||
- as: test | |||
- always_run: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated in 4.13.yaml and 4.14.yaml too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
This test was also disabled upstream: https://github.com/kubernetes/test-infra/pull/26354/files The problem is that sanity tests currently use command faker and only one driver instance. That makes any command faking impossible as the same instance of the driver is re-used in many tests. Relevant discussion upstream is here: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#972 (comment)
88e9c31
to
c63417a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse |
/pj-rehearse ack |
@RomanBednar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@RomanBednar: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This test was also disabled upstream: https://github.com/kubernetes/test-infra/pull/26354/files The problem is that sanity tests currently use command faker and only one driver instance. That makes any command faking impossible as the same instance of the driver is re-used in many tests. Relevant discussion upstream is here: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#972 (comment)
This test was also disabled upstream:
https://github.com/kubernetes/test-infra/pull/26354/files
The problem is that sanity tests currently use command faker and only one driver instance. That makes any command faking impossible as the same instance of the driver is re-used in many tests. Relevant discussion upstream is here:
kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#972 (comment)
cc @openshift/storage for approval