Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp-pd-csi-driver: disable auto run of sanity tests #36246

Merged

Conversation

RomanBednar
Copy link
Contributor

This test was also disabled upstream:
https://github.com/kubernetes/test-infra/pull/26354/files

The problem is that sanity tests currently use command faker and only one driver instance. That makes any command faking impossible as the same instance of the driver is re-used in many tests. Relevant discussion upstream is here:
kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#972 (comment)

cc @openshift/storage for approval

@openshift-ci-robot
Copy link
Contributor

@RomanBednar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-gcp-pd-csi-driver-master-test openshift/gcp-pd-csi-driver presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana February 10, 2023 08:54
@RomanBednar RomanBednar force-pushed the gcp-pd-sanity-no-autorun branch from 493187f to 88e9c31 Compare February 10, 2023 10:04
@@ -39,7 +39,8 @@ resources:
cpu: 100m
memory: 200Mi
tests:
- as: test
- always_run: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated in 4.13.yaml and 4.14.yaml too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

This test was also disabled upstream:
https://github.com/kubernetes/test-infra/pull/26354/files

The problem is that sanity tests currently use command faker and only
one driver instance. That makes any command faking impossible as
the same instance of the driver is re-used in many tests. Relevant
discussion upstream is here:
kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#972 (comment)
@RomanBednar RomanBednar force-pushed the gcp-pd-sanity-no-autorun branch from 88e9c31 to c63417a Compare February 27, 2023 10:25
@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2023
@jsafrane
Copy link
Contributor

/pj-rehearse

@jsafrane
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/gcp-pd-csi-driver/master/test c63417a link unknown /pj-rehearse pull-ci-openshift-gcp-pd-csi-driver-master-test
ci/rehearse/openshift/gcp-pd-csi-driver/release-4.14/test c63417a link unknown /pj-rehearse pull-ci-openshift-gcp-pd-csi-driver-release-4.14-test
ci/rehearse/openshift/gcp-pd-csi-driver/release-4.13/test c63417a link unknown /pj-rehearse pull-ci-openshift-gcp-pd-csi-driver-release-4.13-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6db4d38 into openshift:master Mar 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

@RomanBednar: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-gcp-pd-csi-driver-master.yaml using file ci-operator/config/openshift/gcp-pd-csi-driver/openshift-gcp-pd-csi-driver-master.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-gcp-pd-csi-driver-release-4.13.yaml using file ci-operator/config/openshift/gcp-pd-csi-driver/openshift-gcp-pd-csi-driver-release-4.13.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-gcp-pd-csi-driver-release-4.14.yaml using file ci-operator/config/openshift/gcp-pd-csi-driver/openshift-gcp-pd-csi-driver-release-4.14.yaml

In response to this:

This test was also disabled upstream:
https://github.com/kubernetes/test-infra/pull/26354/files

The problem is that sanity tests currently use command faker and only one driver instance. That makes any command faking impossible as the same instance of the driver is re-used in many tests. Relevant discussion upstream is here:
kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#972 (comment)

cc @openshift/storage for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bmanzari pushed a commit to bmanzari/release that referenced this pull request Mar 30, 2023
This test was also disabled upstream:
https://github.com/kubernetes/test-infra/pull/26354/files

The problem is that sanity tests currently use command faker and only
one driver instance. That makes any command faking impossible as
the same instance of the driver is re-used in many tests. Relevant
discussion upstream is here:
kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#972 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants