Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.18] OCPBUGS-49833: extensions: include release and arch in extensions.json #1739

Closed
wants to merge 1 commit into from

Conversation

ravanelli
Copy link
Member

%{version} just prints the version field, but we want the epoch, release, and arch too. This matches what we previously would output before moving extensions building to a container.

There is code that will parse this metadata assuming that it's an EVRA:

https://github.com/openshift-eng/art-tools/blob/6a29949b2b2819afe00829646e6c7db9b784ff8a/doozer/doozerlib/rhcos.py#L248 (cherry picked from commit 51e149d)

`%{version}` just prints the version field, but we want the epoch,
release, and arch too. This matches what we previously would output
before moving extensions building to a container.

There is code that will parse this metadata assuming that it's an EVRA:

https://github.com/openshift-eng/art-tools/blob/6a29949b2b2819afe00829646e6c7db9b784ff8a/doozer/doozerlib/rhcos.py#L248
(cherry picked from commit 51e149d)
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 5, 2025
@openshift-ci-robot
Copy link

@ravanelli: This pull request references Jira Issue OCPBUGS-49833, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-49831 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-49831 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

%{version} just prints the version field, but we want the epoch, release, and arch too. This matches what we previously would output before moving extensions building to a container.

There is code that will parse this metadata assuming that it's an EVRA:

https://github.com/openshift-eng/art-tools/blob/6a29949b2b2819afe00829646e6c7db9b784ff8a/doozer/doozerlib/rhcos.py#L248 (cherry picked from commit 51e149d)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravanelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@ravanelli: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mike-nguyen
Copy link
Member

@ravanelli I used the bot and it merged #1738 sorry for the duplicated efforts

@ravanelli
Copy link
Member Author

Not at all, thanks @mike-nguyen!

@ravanelli ravanelli closed this Feb 5, 2025
@openshift-ci-robot
Copy link

@ravanelli: This pull request references Jira Issue OCPBUGS-49833. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

%{version} just prints the version field, but we want the epoch, release, and arch too. This matches what we previously would output before moving extensions building to a container.

There is code that will parse this metadata assuming that it's an EVRA:

https://github.com/openshift-eng/art-tools/blob/6a29949b2b2819afe00829646e6c7db9b784ff8a/doozer/doozerlib/rhcos.py#L248 (cherry picked from commit 51e149d)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants