-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rhcos-4.18] - Backport Fix missing extensions in RHCOS release browser #4017
Conversation
- Make `path`, `sha256` and `rpm-ostree-state` optional fields in `meta.json` for extensions, as no tar file was ever stored as an artifact. Including references to a non-existent file is unnecessary. Signed-off-by: Renata Ravanelli <[email protected]> (cherry picked from commit 7c3d186)
- Fix an issue where extensions were not displayed in the RHCOS release browser for versions 4.16 and later. Signed-off-by: Renata Ravanelli <[email protected]> (cherry picked from commit 7122058)
- The repository https://github.com/idubinskiy/schematyper has not seen any commits in 7 years and appears to be unmaintained. Since the package `alecthomas/kingpin` name has changed, fix it and build it locally. This avoids relying on `go install` and allows us to make necessary fixes to the package as needed. Signede off-by: Renata Ravanelli <[email protected]> (cherry picked from commit d87064a)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We need to backport the Dockerfile changes before these branches merge, correct? |
Yes, otherwise the CI won't pass |
It depends on: openshift/os#1732 |
/retest |
1 similar comment
/retest |
A ok, it is failing with an old issue, the https://kojipkgs.fedoraproject.org/repos-dist/f40-coreos-continuous/ doesn't have the |
/retest |
/hold |
/unhold |
No description provided.