Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhcos-4.18] - Backport Fix missing extensions in RHCOS release browser #4017

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

ravanelli
Copy link
Member

No description provided.

- Make `path`, `sha256` and `rpm-ostree-state` optional fields in `meta.json`
for extensions, as no tar file was ever stored as an artifact.
Including references to a non-existent file is unnecessary.

Signed-off-by: Renata Ravanelli <[email protected]>
(cherry picked from commit 7c3d186)
- Fix an issue where extensions were not displayed in
the RHCOS release browser for versions 4.16 and later.

Signed-off-by: Renata Ravanelli <[email protected]>
(cherry picked from commit 7122058)
- The repository https://github.com/idubinskiy/schematyper has not seen
any commits in 7 years and appears to be unmaintained. Since the package
`alecthomas/kingpin` name has changed, fix it and build it locally. This
avoids relying on `go install` and allows us to make necessary
fixes to the package as needed.

Signede off-by: Renata Ravanelli <[email protected]>

(cherry picked from commit d87064a)
@ravanelli ravanelli requested review from dustymabe and jlebon January 31, 2025 17:33
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dustymabe
Copy link
Member

We need to backport the Dockerfile changes before these branches merge, correct?

@ravanelli
Copy link
Member Author

We need to backport the Dockerfile changes before these branches merge, correct?

Yes, otherwise the CI won't pass

@ravanelli
Copy link
Member Author

It depends on: openshift/os#1732

@ravanelli
Copy link
Member Author

/retest

1 similar comment
@ravanelli
Copy link
Member Author

/retest

@ravanelli
Copy link
Member Author

A ok, it is failing with an old issue, the https://kojipkgs.fedoraproject.org/repos-dist/f40-coreos-continuous/ doesn't have the latest tag anymore. @dustymabe you mentioned you fixed it with an workaround the other day? How did you do it? It is failing for prow now.

@mike-nguyen
Copy link
Member

/retest
I think dusty fixed it. https://pagure.io/koji/issue/4295#comment-953957

@ravanelli
Copy link
Member Author

/hold
Art found an issue at their side, we also need: openshift/os#1739

@ravanelli
Copy link
Member Author

/unhold
Fixed on openshift/os#1738

@ravanelli ravanelli merged commit c461f65 into coreos:rhcos-4.18 Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants