Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip whitespace in AllowAllPasswordIdentityProvider, add auth logging #7425

Merged
merged 2 commits into from
Feb 19, 2016
Merged

Strip whitespace in AllowAllPasswordIdentityProvider, add auth logging #7425

merged 2 commits into from
Feb 19, 2016

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Feb 18, 2016

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1309566 for AllowAllPasswordIdentityProvider

@liggitt liggitt changed the title Strip whitespace in AllowAnyPassword Strip whitespace in AllowAllPasswordIdentityProvider Feb 18, 2016
@liggitt liggitt changed the title Strip whitespace in AllowAllPasswordIdentityProvider Strip whitespace in AllowAllPasswordIdentityProvider, add auth logging Feb 18, 2016
@liggitt
Copy link
Contributor Author

liggitt commented Feb 19, 2016

[test]

@liggitt
Copy link
Contributor Author

liggitt commented Feb 19, 2016

protractor test flake #6618
[test]

@deads2k
Copy link
Contributor

deads2k commented Feb 19, 2016

protractor test flake #6618
[test]

Please add flake indications: https://ci.openshift.redhat.com/jenkins/failure-cause-management/ . I added one for this.

@deads2k
Copy link
Contributor

deads2k commented Feb 19, 2016

The commits look unrelated, but other than one minor comment and thinking that allowing bob, bob, and bob is asking for future pain we don't need (disallowing it, they'd get pain they deserve and never ask us about it), it looks ok.

@liggitt
Copy link
Contributor Author

liggitt commented Feb 19, 2016

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5037/) (Image: devenv-rhel7_3482)

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to dfa3fd8

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1388/)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to dfa3fd8

openshift-bot pushed a commit that referenced this pull request Feb 19, 2016
Merge pull request #7425 from liggitt/whitespace-user
c8977d3 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit c8977d3 into openshift:master Feb 19, 2016
@liggitt liggitt deleted the whitespace-user branch February 20, 2016 02:54
@liggitt liggitt mentioned this pull request Apr 22, 2016
Closed
@liggitt liggitt mentioned this pull request Jun 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @deads2k @openshift-bot