-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(google.golang.org/grpc): 708a7f9f3283aa2d4f6132d287d78683babe55c8 #18071
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: soltysh Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
What commits were there after this to the next major release of gRPC? Any risk of this introducing breaks fixed immediately after this commit? |
/test all |
@smarterclayton the big changes are: adding stats (grpc/grpc-go#961) and server list expiration (grpc/grpc-go#962). Two experimental things added are: 1 the transport tap (grpc/grpc-go#968), 2. FailOnNonTempDialError (grpc/grpc-go#985), although that shouldn't bite us since you need to configure them separately. So it looks like we should be kind of good. |
The test error seems to be a known flake #11114. But |
@smarterclayton @soltysh the diff looks scary, +4,355 −144 ? I still think that we should go with one cherry-pick to fix the issue and stay closer to upstream if possible. |
The diff contains a quite a lot of .md files modifications. See one of my previous comments about the scope of the changes here. Flake #15418. |
/test all |
Multiple time-outs during test. /test all |
/retest |
Closing in favor of #17735. |
@mfojtik @smarterclayton the bump looks reasonable, although I'm yet to carefully go through every change. Let's see how our tests infra likes it.