-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct serialisation of tsb json schemas #14442
Conversation
@jim-minter is there a reason camel case is not used? |
@csrwng The property name comes from the OpenService Broker API spec, so it's not something we can change. Currently still a proposal in OpenService Broker API, but implemented by service catalog as an alpha feature. |
Thanks @jim-minter parameters are coming through for me with this change: @pmorie fyi |
LGTM |
@jim-minter Looks like it's changing in the OSB spec to kubernetes-retired/service-catalog#912 cc @pmorie |
56a48c4
to
29daf8e
Compare
@jim-minter unless this is a blocker, I will merge on Monday |
[merge] |
Evaluated for origin merge up to 29daf8e |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to 29daf8e |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1928/) (Base Commit: 92cdd00) |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/903/) (Base Commit: 8f20c19) (Image: devenv-rhel7_6314) |
fixes #14439