Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct serialisation of tsb json schemas #14442

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

jim-minter
Copy link
Contributor

fixes #14439

@csrwng
Copy link
Contributor

csrwng commented Jun 1, 2017

@jim-minter is there a reason camel case is not used?

@spadgett
Copy link
Member

spadgett commented Jun 1, 2017

@csrwng The property name comes from the OpenService Broker API spec, so it's not something we can change. Currently still a proposal in OpenService Broker API, but implemented by service catalog as an alpha feature.

@spadgett
Copy link
Member

spadgett commented Jun 1, 2017

Thanks @jim-minter parameters are coming through for me with this change:

openshift catalog components 2017-06-01 14-50-58

@pmorie fyi

@csrwng
Copy link
Contributor

csrwng commented Jun 1, 2017

LGTM

@spadgett
Copy link
Member

spadgett commented Jun 1, 2017

@jim-minter Looks like it's changing in the OSB spec to service_instance and service_binding. See

kubernetes-retired/service-catalog#912

cc @pmorie

@jim-minter
Copy link
Contributor Author

thanks @spadgett PR updated to today's version of the spec. @csrwng please merge.

@csrwng
Copy link
Contributor

csrwng commented Jun 2, 2017

@jim-minter unless this is a blocker, I will merge on Monday

@csrwng
Copy link
Contributor

csrwng commented Jun 5, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 29daf8e

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 29daf8e

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1928/) (Base Commit: 92cdd00)

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/903/) (Base Commit: 8f20c19) (Image: devenv-rhel7_6314)

@openshift-bot openshift-bot merged commit d973e45 into openshift:master Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template broker sends service-instances instead of service_instances in parameter schemas object
4 participants