Skip to content
This repository was archived by the owner on May 6, 2022. It is now read-only.

Correct parameter schema support #912

Merged
merged 1 commit into from
Jun 1, 2017

Conversation

pmorie
Copy link
Contributor

@pmorie pmorie commented Jun 1, 2017

After #822, @spadgett discovered that the proposal (openservicebrokerapi/servicebroker#165) was internally inconsistent. After the inconsistencies were corrected, we discovered that #822 was not 100% correct in its implementation of the API proposal.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2017
@pmorie pmorie added this to the 0.0.10 milestone Jun 1, 2017
@arschles arschles added the LGTM1 label Jun 1, 2017
@vaikas vaikas added the LGTM2 label Jun 1, 2017
@pmorie pmorie force-pushed the parameter-schema branch from 81fed5f to f0f4c66 Compare June 1, 2017 21:12
@jpeeler jpeeler added the LGTM3 label Jun 1, 2017
@jpeeler jpeeler merged commit f4233a0 into kubernetes-retired:master Jun 1, 2017
@sas977
Copy link

sas977 commented Jun 1, 2017

Hi ok

"create": {
"zoo": "blu"
"parameters": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that the formatting looks off via the web, but looking at the code its ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, tabs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 LGTM3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants