Make the OS_RELEASE=n ./hack/build-images.sh work again

[miminar]

Make the OS_RELEASE=n ./hack/build-images.sh work again

Without this patch, I get:

$ OS_RELEASE=n ./hack/build-images.sh
Building images from source v1.5.0-alpha.2-78d8140-6-dirty:

++ temporarily enabling swap space to assist in building in limited memory - use OS_BUILD_SWAP_DISABLE=1 to bypass
/data/src/github.com/openshift/origin/hack/common.sh: line 295: platforms[@]: unbound variable


$ OS_RELEASE=n ./hack/build-images.sh
Building images from source v1.5.0-alpha.2-78d8140-6-dirty:

OS_IMAGE_COMPILE_TARGETS:
++ temporarily enabling swap space to assist in building in limited memory - use OS_BUILD_SWAP_DISABLE=1 to bypass
++ Building go targets for linux/amd64:
++ Placing binaries

ln: failed to access '/data/src/github.com/openshift/origin/_output/local/bin/linux/amd64/pod': No such file or directory

[miminar]

@stevekuznetsov PTAL

[stevekuznetsov]

@smarterclayton PTAL

[mmilata]

Fixes the problem for me.

FYI there's a merge conflict with #12548 which is in the process of merging.

[stevekuznetsov]

Yeah, we'll work through it. Glad to hear it works for you.

[stevekuznetsov]

@smarterclayton with regards to our last conversation ... do we just want to remove this section and have a build be a strict pre-req for images? I don't like how this stanza muddles the build flow.

[smarterclayton]

I'm ok as long as our consumers have another path that they feel happy with. I don't like having it here either.

[miminar]

Rebased. I don't like it either. I leave the decision up to you .. merge or do it other way.

[stevekuznetsov]

Ok. I'll clean it up in a follow-up. [merge]

[openshift-bot]

Evaluated for origin merge up to 91f8b59

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

Evaluated for origin test up to 91f8b59

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13238/) (Base Commit: c5868ac)

[miminar]

Flake #12362 (job https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13238/).

[smarterclayton]

That issue is not a flake issue, it's an issue saying that the test does not run on a cluster, only when you are local to the machine. Needs another flake issue :)

…

On Tue, Jan 24, 2017 at 10:08 AM, Michal Minář ***@***.***> wrote: Flake #12362 <#12362> (job https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13238/). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12561 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p6BugdRephS5kFRqqwXQEeGm7e69ks5rVhPagaJpZM4LoJdf> .

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13279/) (Base Commit: 86a9783) (Image: devenv-rhel7_5769)