Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build non-release images #12581

Closed
mmilata opened this issue Jan 20, 2017 · 4 comments
Closed

Cannot build non-release images #12581

mmilata opened this issue Jan 20, 2017 · 4 comments
Assignees
Labels
component/internal-tools kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@mmilata
Copy link
Contributor

mmilata commented Jan 20, 2017

Version

git master / 1ccbb6c

Steps To Reproduce
$ git checkout master
$ git reset --hard origin/master
$ make clean
$ make
++ Building go targets for linux/amd64: cmd/openshift cmd/oc pkg/sdn/plugin/sdn-cni-plugin vendor/github.com/containernetworking/cni/plugins/ipam/host-local vendor/github.com/containernetworking/cni/plugins/main/loopback
++ Placing binaries
hack/build-go.sh took 688 seconds
$ OS_RELEASE=n hack/build-images.sh
Building images from source v1.5.0-alpha.2-1ccbb6c-45:

hack/build-images.sh: line 23: OS_IMAGE_COMPILE_GOFLAGS: unbound variable

I tried to workaround the unbound variables but there are further errors like the pod binary not being built. The same steps worked couple of days ago, though.

@stevekuznetsov
Copy link
Contributor

Fixed in #12548

@mmilata
Copy link
Contributor Author

mmilata commented Jan 20, 2017

@stevekuznetsov tested the patch, now I'm getting:

[root@localhost origin]# OS_RELEASE=n hack/build-images.sh 
Building images from source v1.5.0-alpha.2-a63a831-47-dirty:

/data/src/github.com/openshift/origin/hack/common.sh: line 295: platforms[@]: unbound variable
[ERROR] PID 5293: hack/common.sh:238: `( os::build::internal::build_binaries "${binaries[@]+"${binaries[@]}"}" )` exited with status 1.
[INFO]          Stack Trace: 
[INFO]            1: hack/common.sh:238: `( os::build::internal::build_binaries "${binaries[@]+"${binaries[@]}"}" )`
[INFO]            2: hack/common.sh:227: os::build::build_binaries
[INFO]            3: hack/build-images.sh:23: os::build::build_static_binaries
[INFO]   Exiting with code 1.

@stevekuznetsov
Copy link
Contributor

@mmilata that's fixed in #12561

@stevekuznetsov
Copy link
Contributor

Fixes merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/internal-tools kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Development

No branches or pull requests

3 participants