Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated evacuate in favor of drain node #11803

Merged
merged 1 commit into from
Nov 7, 2016

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Nov 7, 2016

Fixes: #11310

@mfojtik
Copy link
Contributor Author

mfojtik commented Nov 7, 2016

@Kargakis @smarterclayton PTAL

@soltysh
Copy link
Contributor

soltysh commented Nov 7, 2016

LGTM

@mfojtik mfojtik force-pushed the deprecate-evacuate branch from eb177b4 to 89d407d Compare November 7, 2016 09:26
@0xmichalis
Copy link
Contributor

LGTM

@mfojtik
Copy link
Contributor Author

mfojtik commented Nov 7, 2016

[merge]

@mfojtik
Copy link
Contributor Author

mfojtik commented Nov 7, 2016

@sdodson dunno if ansible use evacuate, but you might consider switching it.

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 89d407d

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 7, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11192/) (Base Commit: 058a0d8) (Image: devenv-rhel7_5326)

@openshift-bot openshift-bot merged commit 704ab21 into openshift:master Nov 7, 2016
@sdodson
Copy link
Member

sdodson commented Nov 7, 2016

@sdodson dunno if ansible use evacuate, but you might consider switching it.

we do, thanks. Just to be clear this is deprecated in 1.4 and removed in 1.5?

@smarterclayton
Copy link
Contributor

Does drain do everything that evacuate does? If there are gaps, we can't
remove until the gaps are closed.

On Nov 7, 2016, at 6:36 AM, Scott Dodson [email protected] wrote:

@sdodson https://github.com/sdodson dunno if ansible use evacuate, but
you might consider switching it.

we do, thanks. Just to be clear this is deprecated in 1.4 and removed in
1.5?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11803 (comment),
or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABG_p6SCTafk7sq491U1Xfc0EVtqat70ks5q7zdsgaJpZM4Kq-of
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants