Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify evacuate code #11310

Closed
soltysh opened this issue Oct 11, 2016 · 4 comments
Closed

Simplify evacuate code #11310

soltysh opened this issue Oct 11, 2016 · 4 comments
Assignees
Milestone

Comments

@soltysh
Copy link
Contributor

soltysh commented Oct 11, 2016

Currently our oadm manage-node --evacuate code is filled with all sorts of controller checks to make sure we properly identify pods during node evacuation. We should ensure all controllers have controllerRef set (as proposed in kubernetes/kubernetes#24946) to be able to have a generic code in the evacuation.

@mfojtik fyi

@mfojtik
Copy link
Contributor

mfojtik commented Oct 11, 2016

@soltysh the old servers will not have that annotation set, so we will always need to carry the "legacy" code in case not all pods respects that annotation.

@soltysh
Copy link
Contributor Author

soltysh commented Oct 12, 2016

First we need to make sure ALL controllers set this annotation accordingly, once that is done we'll have to do version dependent logic. Since, old clusters won't have all the resources you were adding in your PR, either.

@smarterclayton
Copy link
Contributor

We need to move people to using drain and deprecate and remove --evacuate.

@mfojtik
Copy link
Contributor

mfojtik commented Nov 7, 2016

@smarterclayton PR opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants