Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto deploy in pipeline template #11637

Closed
wants to merge 1 commit into from

Conversation

dongboyan77
Copy link

@dongboyan77 dongboyan77 commented Oct 28, 2016

To bz , could I disable auto deploy in pipeline build template? Thanks @bparees

@bparees
Copy link
Contributor

bparees commented Oct 28, 2016

@mfojtik will this work these days? last i knew we needed the ICT and automatic=true if we wanted imagestream resolution.

@bparees
Copy link
Contributor

bparees commented Oct 28, 2016

@Kargakis

@0xmichalis
Copy link
Contributor

You can have manual deployments with oc rollout latest (and auto=false) in 1.4

@bparees
Copy link
Contributor

bparees commented Oct 28, 2016

@Kargakis that doesn't help since in our case the deployment is triggered by the jenkins job, but i think you had @gabemontero update the jenkins plugin to use the instantiate endpoint so in theory that means this would work ok?

@0xmichalis
Copy link
Contributor

Yes, oc rollout latest uses the instantiate endpoint too

@bparees
Copy link
Contributor

bparees commented Oct 28, 2016

tested this w/ the latest jenkins image and it appears to work correctly.
[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 28, 2016

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 3

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 3c6faf8

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 3c6faf8

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10801/) (Base Commit: 90c7b56)

@bparees
Copy link
Contributor

bparees commented Oct 28, 2016

flake #11114
flake #10336

@dongboyan77 this also needs hack/update-generated-bootstrap.sh run, but i've created another PR that includes this change and another one, so i'm going to just close this:
#11646

@bparees bparees closed this Oct 28, 2016
@dongboyan77
Copy link
Author

@bparees ok, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants