Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GitLab Push Event #11031

Merged
merged 2 commits into from
Sep 26, 2016
Merged

Add support for GitLab Push Event #11031

merged 2 commits into from
Sep 26, 2016

Conversation

vanloswang
Copy link

Enable WebHook for build intergrated with GitLab Push Event, fix #11002

@vanloswang vanloswang mentioned this pull request Sep 21, 2016
Closed
@bparees bparees self-assigned this Sep 21, 2016
@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@mfojtik
Copy link
Contributor

mfojtik commented Sep 21, 2016

these two tests have to be fixed:

github.com/openshift/origin/pkg/build/webhook/github.TestMissingEvent
github.com/openshift/origin/pkg/build/webhook/github.TestWrongGitHubEvent

@vanloswang
Copy link
Author

@bparees @mfojtik checks passed.

@bparees
Copy link
Contributor

bparees commented Sep 22, 2016

lgtm, please squash your commits (http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) and i'll merge.

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to ca6be6d

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9135/)

@bparees
Copy link
Contributor

bparees commented Sep 26, 2016

[merge]

@bparees
Copy link
Contributor

bparees commented Sep 26, 2016

#11058
#11094

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 26, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9135/) (Image: devenv-rhel7_5076)

@bparees
Copy link
Contributor

bparees commented Sep 26, 2016

flake #11094
flake #11016

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to ca6be6d

@openshift-bot openshift-bot merged commit 2b02ee4 into openshift:master Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bparees bparees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebHook on GitLab does not work
4 participants
@vanloswang @openshift-bot @mfojtik @bparees