Add support for GitLab Push Event #11007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM @bparees ? |
bparees
requested changes
Sep 20, 2016
| @@ -16,7 +16,7 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| ErrNoGitHubEvent = errors.New("missing X-GitHub-Event or X-Gogs-Event") | |||
| ErrNoGitHubEvent = errors.New("missing X-GitHub-Event or X-Gogs-Event or X-Gitlab-Event") | |||
There was a problem hiding this comment.
please change this text to:
"missing X-GitHub-Event, X-Gogs-Event, or X-Gitlab-Event"
| if method != "ping" && method != "push" { | ||
| return revision, envvars, proceed, fmt.Errorf("Unknown X-GitHub-Event or X-Gogs-Event %s", method) | ||
| if method != "ping" && method != "push" && method != "Push Hook" { | ||
| return revision, envvars, proceed, fmt.Errorf("Unknown X-GitHub-Event or X-Gogs-Event or X-Gitlab-Event %s", method) |
There was a problem hiding this comment.
same message change here (comma separated list instead of multiple ors)
|
@bparees Changed the notice msg. |
|
please squash your commits and lgtm. |
bparees
approved these changes
Sep 20, 2016
|
@vanloswang can you confirm that the gitlab webhok payload is compatible w/ the github push payload? |
|
@vanloswang please squash and i'll merge based on your confirmation in the related issue that this fix works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable WebHook for build intergrated with GitLab Push Event, fix #11002