-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for 3.7 install/upgrade #6434
Conversation
e587270
to
cc0d327
Compare
https://bugzilla.redhat.com/show_bug.cgi?id=1509112 |
@adellape [glusterfs]
192.168.10.11 glusterfs_ip=192.168.10.11 glusterfs_devices='[ "/dev/xvdc", "/dev/xvdd" ]'
192.168.10.12 glusterfs_ip=192.168.10.12 glusterfs_devices='[ "/dev/xvdc", "/dev/xvdd" ]'
192.168.10.13 glusterfs_ip=192.168.10.13 glusterfs_devices='[ "/dev/xvdc", "/dev/xvdd" ]' [nodes]
192.168.10.14
192.168.10.15
192.168.10.16 |
|Logging Install | ||
|*_{pb-prefix}playbooks/byo/openshift-cluster/openshift-logging.yml_* | ||
|
||
|Prometheus Install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to playbook order listed in playbooks/common/openshift-cluster/config.yml, seem like there is no single entrypoint to call openshift-prometheus.yml, while it is already included in openshift_hosted.yml, it seem like a duplicate to list openshift-prometheus.yml here, so I suggest we should remove this line here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prometheus does have an entry point [here](https://github.com/openshift/openshift-ansible/blob/release-3.7/playbooks/byo/openshift-cluster/openshift-prometheus.yml. The call to common/openshift-cluster/openshift_prometheus.yml should not be in common/openshift-cluster/openshift_hosted.yml, but should rather be in common/openshift-cluster/config.yml. I noticed this yesterday when doing the refactoring for 3.8. I will put in a PR to update the 3.7 branch accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, totally agree to move the call for openshift-prometheus.yml from common/openshift-cluster/openshift_hosted.yml to common/openshift-cluster/config.yml. If that, agree to keep this line here.
A couple issues found after having a look of the whole doc:
To get the facts, should run playbook
For a fresh install, we recommend the new parameter
Besides Since OCP 3.7,
Since OCP 3.6(if my memory is correct), containerized LB has been already supported. |
The cli_docker_* options were deprecated, updated as below now. "cafile" key was added in openshift_master_named_certificates option list now openshift_master_named_certificates=[{"certfile": "/path/to/custom1.crt", "keyfile": "/path/to/custom1.key"}] openshift_master_named_certificates=[{"certfile": "/path/to/custom1.crt", "keyfile": "/path/to/custom1.key", "names": ["public-master-host.com"]}] |
63dc67a
to
9523dcc
Compare
@ganhuang Thank you! Edits made, except for the following two points (comments inline):
I will work on this ASAP in a follow-up PR.
I'll need more info on this, so I'll also leave this as is for now and work on it in a follow-up PR. |
@wkshi Thanks! Per your comments:
I'm removing the quick installer from the 3.7 docs, and we'll add a release note to explains it. cc @ahardin-rh
This is now fixed. |
9523dcc
to
23c10fa
Compare
@gpei Thanks! Edits made. |
Add individual component playbooks info
17c3051
to
eee7587
Compare
Add individual component playbooks info (cherry picked from commit 85ac386) xref:openshift#6434
(cherry picked from commit eee7587) xref:openshift#6434
This is the bug which was fixed since 3.5 |
Hi, @adellape another issue found. The data directory used by etcd system container has been changed to /var/lib/etcd |
@adellape apiVersion: servicecatalog.k8s.io/v1beta1 |
@adellape Thanks for the updates! One more typo found in "etcd " group should be added in [OSEv3:children] |
@gpei Thanks! Fixed via #6568. (It was also reported via https://bugzilla.redhat.com/show_bug.cgi?id=1518964). |
Add individual component playbooks info (cherry picked from commit 85ac386) xref:openshift#6434
Add individual component playbooks info (cherry picked from commit 85ac386) xref:openshift#6434
Add individual component playbooks info (cherry picked from commit 85ac386) xref:openshift#6434 (cherry picked from commit 74682d6) xref:null
Add individual component playbooks info (cherry picked from commit 85ac386) xref:openshift#6434 (cherry picked from commit 74682d6) xref:null
http://file.rdu.redhat.com/~adellape/112017/installupgrade37/install_config/index.html