Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 3.7 install/upgrade #6434

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Conversation

adellape
Copy link
Contributor

@adellape adellape commented Nov 20, 2017

@adellape adellape added this to the Future Release milestone Nov 20, 2017
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 20, 2017
@adellape
Copy link
Contributor Author

@adellape adellape force-pushed the installupgrade37 branch 2 times, most recently from e587270 to cc0d327 Compare November 21, 2017 22:54
@adellape adellape changed the title [WIP] Updates for 3.7 install/upgrade Updates for 3.7 install/upgrade Nov 21, 2017
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2017
@adellape
Copy link
Contributor Author

@adellape
Copy link
Contributor Author

@wkshi
Copy link

wkshi commented Nov 22, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1509112
https://bugzilla.redhat.com/show_bug.cgi?id=1509137
@sdodson Due to above bugs, quick installer is totally unable to use. Are we still going to release quick installer in doc?

@wkshi
Copy link

wkshi commented Nov 22, 2017

@adellape
At install_config/install/advanced_install.adoc part, The "Add the hosts listed under [glusterfs] to the [nodes] group as well:" seems give a wrong example ip address:

[glusterfs]
192.168.10.11 glusterfs_ip=192.168.10.11 glusterfs_devices='[ "/dev/xvdc", "/dev/xvdd" ]'
192.168.10.12 glusterfs_ip=192.168.10.12 glusterfs_devices='[ "/dev/xvdc", "/dev/xvdd" ]'
192.168.10.13 glusterfs_ip=192.168.10.13 glusterfs_devices='[ "/dev/xvdc", "/dev/xvdd" ]'
[nodes]
192.168.10.14
192.168.10.15
192.168.10.16

|Logging Install
|*_{pb-prefix}playbooks/byo/openshift-cluster/openshift-logging.yml_*

|Prometheus Install
Copy link

@jianlinliu jianlinliu Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to playbook order listed in playbooks/common/openshift-cluster/config.yml, seem like there is no single entrypoint to call openshift-prometheus.yml, while it is already included in openshift_hosted.yml, it seem like a duplicate to list openshift-prometheus.yml here, so I suggest we should remove this line here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prometheus does have an entry point [here](https://github.com/openshift/openshift-ansible/blob/release-3.7/playbooks/byo/openshift-cluster/openshift-prometheus.yml. The call to common/openshift-cluster/openshift_prometheus.yml should not be in common/openshift-cluster/openshift_hosted.yml, but should rather be in common/openshift-cluster/config.yml. I noticed this yesterday when doing the refactoring for 3.8. I will put in a PR to update the 3.7 branch accordingly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, totally agree to move the call for openshift-prometheus.yml from common/openshift-cluster/openshift_hosted.yml to common/openshift-cluster/config.yml. If that, agree to keep this line here.

@ganhuang
Copy link

ganhuang commented Nov 22, 2017

A couple issues found after having a look of the whole doc:

  1. Overriding Detected IP Addresses and Host Names
# ansible-playbook  [-i /path/to/inventory] \
    ~/openshift-ansible/playbooks/byo/config.yml

To get the facts, should run playbook /usr/share/ansible/openshift-ansible/roles/openshift_facts/library/openshift_facts.py

# ansible-playbook  [-i /path/to/inventory] \
    /usr/share/ansible/openshift-ansible/roles/openshift_facts/library/openshift_facts.py

  1. Configuring Deployment Type

For a fresh install, we recommend the new parameter openshift_deployment_type instead of deployment_type.

  1. Configuring System Containers
You can configure your OpenShift Container Platform installation to run certain components as system containers instead of their RPM or standard containerized methods. Currently, the docker and etcd components can be run as system containers in OpenShift Container Platform.

Besides etcd, docker system containers, we also could enable master, node, openvswitch system containers. Detailed parameters. This is not documented yet.

  1. Multiple Masters Examples

Since OCP 3.7, osm_controller_lease_ttl is deprecated, and the new client based leader election code in the controllers is used as the default. Detailed PR

  1. Install Methods for Containerized Hosts
When installing an environment with multiple masters, the load balancer cannot be deployed by the installation process as a container. See Advanced Installation for load balancer requirements using the native HA method.

Since OCP 3.6(if my memory is correct), containerized LB has been already supported.

@gpei
Copy link

gpei commented Nov 22, 2017

1.http://file.rdu.redhat.com/~adellape/110117/cfme37/install_config/install/rpm_vs_containerized.html#containerized-required-images

The cli_docker_* options were deprecated, updated as below now.
#openshift_docker_additional_registries=registry.example.com
#openshift_docker_insecure_registries=registry.example.com
#openshift_docker_blocked_registries=registry.hacker.com

  1. http://file.rdu.redhat.com/~adellape/110117/cfme37/install_config/install/advanced_install.html#advanced-install-custom-certificates

"cafile" key was added in openshift_master_named_certificates option list now

openshift_master_named_certificates=[{"certfile": "/path/to/custom1.crt", "keyfile": "/path/to/custom1.key"}]
was changed to
openshift_master_named_certificates=[{"certfile": "/path/to/custom1.crt", "keyfile": "/path/to/custom1.key", "cafile": "/path/to/custom-ca1.crt"}]

openshift_master_named_certificates=[{"certfile": "/path/to/custom1.crt", "keyfile": "/path/to/custom1.key", "names": ["public-master-host.com"]}]
was changed to
openshift_master_named_certificates=[{"certfile": "/path/to/custom1.crt", "keyfile": "/path/to/custom1.key", "names": ["public-master-host.com"], "cafile": "/path/to/custom-ca1.crt"}]

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 22, 2017
@adellape
Copy link
Contributor Author

@ganhuang Thank you! Edits made, except for the following two points (comments inline):

  1. Configuring System Containers
You can configure your OpenShift Container Platform installation to run certain components as system containers instead of their RPM or standard containerized methods. Currently, the docker and etcd components can be run as system containers in OpenShift Container Platform.

Besides etcd, docker system containers, we also could enable master, node, openvswitch system containers. Detailed parameters. This is not documented yet.

I will work on this ASAP in a follow-up PR.

  1. Install Methods for Containerized Hosts
When installing an environment with multiple masters, the load balancer cannot be deployed by the installation process as a container. See Advanced Installation for load balancer requirements using the native HA method.

Since OCP 3.6(if my memory is correct), containerized LB has been already supported.

I'll need more info on this, so I'll also leave this as is for now and work on it in a follow-up PR.

@adellape
Copy link
Contributor Author

@wkshi Thanks! Per your comments:

https://bugzilla.redhat.com/show_bug.cgi?id=1509112
https://bugzilla.redhat.com/show_bug.cgi?id=1509137
@sdodson Due to above bugs, quick installer is totally unable to use. Are we still going to release quick installer in doc?

I'm removing the quick installer from the 3.7 docs, and we'll add a release note to explains it. cc @ahardin-rh

At install_config/install/advanced_install.adoc part, The "Add the hosts listed under [glusterfs] to the [nodes] group as well:" seems give a wrong example ip address:

This is now fixed.

@adellape
Copy link
Contributor Author

@gpei Thanks! Edits made.

@adellape adellape merged commit 5be83b0 into openshift:master Nov 22, 2017
adellape added a commit to adellape/openshift-docs that referenced this pull request Nov 22, 2017
Add individual component playbooks info

(cherry picked from commit 85ac386) xref:openshift#6434
adellape added a commit to adellape/openshift-docs that referenced this pull request Nov 22, 2017
@ganhuang
Copy link

@adellape

  1. Install Methods for Containerized Hosts
When installing an environment with multiple masters, the load balancer cannot be deployed by the installation process as a container. See Advanced Installation for load balancer requirements using the native HA method.

Since OCP 3.6(if my memory is correct), containerized LB has been already supported.
I'll need more info on this, so I'll also leave this as is for now and work on it in a follow-up PR.

This is the bug which was fixed since 3.5

@gpei
Copy link

gpei commented Nov 23, 2017

Hi, @adellape another issue found.
In http://file.rdu.redhat.com/~adellape/110117/cfme37/install_config/install/advanced_install.html#advanced-install-etcd-system-container
The data directory for etcd using this method is /var/lib/etcd/etcd.etcd/etcd.etcd/member

The data directory used by etcd system container has been changed to /var/lib/etcd
per openshift/openshift-ansible@657cf2a

@wmengRH
Copy link

wmengRH commented Nov 23, 2017

@adellape
in file architecture/service_catalog/index.adoc, "Service Plan" should be "Cluster Service Plan" for OCP 3.7 GA

apiVersion: servicecatalog.k8s.io/v1beta1
kind: ClusterServicePlan

@adellape
Copy link
Contributor Author

@ganhuang @gpei @wmengRH Thanks so much! Latest comments addressed via #6517.

@gpei
Copy link

gpei commented Nov 29, 2017

@adellape Thanks for the updates! One more typo found in
"Single Master and Multiple Nodes Inventory File" http://file.rdu.redhat.com/~adellape/112817/edit_installupgrade/install_config/install/advanced_install.html#single-master

"etcd " group should be added in [OSEv3:children]

@adellape
Copy link
Contributor Author

@gpei Thanks! Fixed via #6568. (It was also reported via https://bugzilla.redhat.com/show_bug.cgi?id=1518964).

adellape added a commit to adellape/openshift-docs that referenced this pull request Dec 7, 2017
Add individual component playbooks info

(cherry picked from commit 85ac386) xref:openshift#6434
adellape added a commit to adellape/openshift-docs that referenced this pull request Dec 7, 2017
Add individual component playbooks info

(cherry picked from commit 85ac386) xref:openshift#6434
adellape added a commit to adellape/openshift-docs that referenced this pull request Dec 8, 2017
Add individual component playbooks info

(cherry picked from commit 85ac386) xref:openshift#6434

(cherry picked from commit 74682d6) xref:null
adellape added a commit to adellape/openshift-docs that referenced this pull request Dec 8, 2017
Add individual component playbooks info

(cherry picked from commit 85ac386) xref:openshift#6434

(cherry picked from commit 74682d6) xref:null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/dedicated branch/enterprise-3.7 branch/online size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants