actuators/machine: Fix "Coud" -> "Could" typo #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the misspelling from cd386e4 (Always log errors creating machines and volumes, 2018-09-12, openshift#14). I also like to downcase these to conform to [1], although as discussed there that's not required for logs. But in this commit I've left it for consistency with the package's other logs: $ sudo crictl logs --tail 5 06c3b913cf5e2 I0923 05:25:10.018081 1 controller.go:123] reconciling machine object worker-f55vm triggers idempotent create. I0923 05:25:10.022519 1 actuator.go:46] Creating machine "worker-f55vm" for cluster "trking-01e8e". I0923 05:25:10.032481 1 logs.go:41] [INFO] Created libvirt client I0923 05:25:10.032512 1 logs.go:41] [DEBUG] Create a libvirt volume with name worker-f55vm for pool default from the base volume /var/lib/libvirt/images/coreos_base E0923 05:25:10.040398 1 actuator.go:50] Coud not create libvirt machine: error creating volume: Can't retrieve volume /var/lib/libvirt/images/coreos_base [1]: https://github.com/golang/go/wiki/CodeReviewComments#error-strings Reported-by: Matt Rogers <[email protected]>
openshift-ci-robot
added
the
size/XS
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spangenberg, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the misspelling from cd386e4 (#14).
I also like to downcase these to conform to the Go error guidelines, although as discussed there that's not required for logs. But in this commit I've left it for consistency with the package's other logs:
Reported by @mrogers950.