Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile #14

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Fix Dockerfile #14

merged 2 commits into from
Sep 13, 2018

Conversation

bison
Copy link
Contributor

@bison bison commented Sep 12, 2018

I had trouble running the Docker image because the libvirt libraries were missing. This adds them, and always logs errors in the Create() call.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2018
@openshift-ci-robot
Copy link
Contributor

@bison: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/golint cd386e4 link /test golint
ci/prow/unit cd386e4 link /test unit
ci/prow/go-vet cd386e4 link /test go-vet

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Sep 12, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2018
@spangenberg
Copy link
Contributor

/lgtm

@bison
Copy link
Contributor Author

bison commented Sep 12, 2018

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bison, enxebre, spangenberg
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paulfantom paulfantom merged commit 7e3b2dc into openshift:master Sep 13, 2018
wking added a commit to wking/cluster-api-provider-libvirt that referenced this pull request Sep 23, 2018
@wking
actuators/machine: Fix "Coud" -> "Could" typo
a34b9db 
Fix the misspelling from cd386e4 (Always log errors creating machines
and volumes, 2018-09-12, openshift#14).

I also like to downcase these to conform to [1], although as discussed
there that's not required for logs.  But in this commit I've left it
for consistency with the package's other logs:

  $ sudo crictl logs --tail 5 06c3b913cf5e2
  I0923 05:25:10.018081       1 controller.go:123] reconciling machine object worker-f55vm triggers idempotent create.
  I0923 05:25:10.022519       1 actuator.go:46] Creating machine "worker-f55vm" for cluster "trking-01e8e".
  I0923 05:25:10.032481       1 logs.go:41] [INFO] Created libvirt client
  I0923 05:25:10.032512       1 logs.go:41] [DEBUG] Create a libvirt volume with name worker-f55vm for pool default from the base volume /var/lib/libvirt/images/coreos_base
  E0923 05:25:10.040398       1 actuator.go:50] Coud not create libvirt machine: error creating volume: Can't retrieve volume /var/lib/libvirt/images/coreos_base

[1]: https://github.com/golang/go/wiki/CodeReviewComments#error-strings

Reported-by: Matt Rogers <[email protected]>
@wking wking mentioned this pull request Sep 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spangenberg spangenberg

@enxebre enxebre

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bison @openshift-ci-robot @enxebre @spangenberg @paulfantom