Allow periods in the name field #452

mihnjong · 2018-02-13T22:05:03Z

Service class and plan names can contain periods (".").

closes: #442

cfdreddbot · 2018-02-13T22:05:05Z

Hey mihnjong!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

duglin · 2018-02-20T13:26:56Z

removing L GTM due to CLA not being there.
@mihnjong can you sign the CLA?

mihnjong · 2018-02-21T08:04:17Z

For this change, I worked as a Google employee. which form should I sign?

duglin · 2018-02-21T15:16:21Z

@chipchilders can you answer @mihnjong's question? I'm not familiar enough with the CLA process.

chipchilders · 2018-02-21T17:00:17Z

@mihnjong you need to be a publicly listed member of the GoogleCloudPlatform GH org for the Google CLA to cover your contribution. That's the GH org that Google identified as the right org for us to use in the bot. Alternatively you can follow the ICLA instructions to sign as yourself (which assumes you have your employer's permission to do so).

cfdreddbot · 2018-02-21T18:06:34Z

Hey mihnjong!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

mihnjong · 2018-02-21T18:07:38Z

@n3wscott helped me to make visible my organization status. I guess the PR is good to go now :)

chipchilders · 2018-02-21T18:09:10Z

close / open to kick the bot

chipchilders · 2018-02-21T18:09:14Z

close / open to kick the bot

cfdreddbot · 2018-02-21T18:09:15Z

Hey mihnjong!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

chipchilders · 2018-02-21T18:10:12Z

@mihnjong still not publicly listing you as part of the GoogleCloudPlatform GH org. I only see the Google GH org in your profile.

cfdreddbot · 2018-02-21T23:40:00Z

Hey mihnjong!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

n3wscott · 2018-02-21T23:41:00Z

LGTM

duglin · 2018-02-22T00:35:58Z

LGTM

duglin · 2018-02-27T01:41:21Z

2 more needed

fmui · 2018-02-27T17:37:01Z

LGTM

mattmcneeney · 2018-02-27T17:44:52Z

LGTM but conflicts need fixing @mihnjong

duglin · 2018-03-06T06:23:20Z

@mihnjong can you rebase to fix the conflict?

subhankarc · 2018-03-08T09:39:29Z

Hi,

Will this improvement be part of v2.13? Eagerly waiting for it. We also have a similar use-case where plan names contain version number which includes periods.

Regards,
Subhankar

duglin · 2018-03-08T15:10:39Z

@mihnjong can you rebase please?

@subhankarc I expect it to be part of v2.13 but when it will appear in Kube and CF is up to those projects. Once approved, I think Kube should be able to add it within days, but I can't speak for CF. @mattmcneeney

Service class and plan names can contain periods (".").

duglin · 2018-03-12T23:32:27Z

@mihnjong I did the rebase for you - hope that's ok

duglin · 2018-03-13T00:05:27Z

LGTM

3 more reviews needed

n3wscott · 2018-03-13T15:00:23Z

LGTM

fmui · 2018-03-13T16:35:14Z

LGTM

vaikas · 2018-03-13T18:14:28Z

LGTM

mihnjong · 2018-03-15T06:42:52Z

Sorry.. I was swamped with other work. Thanks @duglin !

…cebroker#452).

…icebroker#452).

)

…service-catalog/' changes from c3e3071633..231772fcc0 231772fcc0 origin build: add origin tooling 98af588 v0.1.11 release changes 01e2f90 v0.1.10 release changes 49af948 clear polling queue before starting new operation (openshift#1855) 252958e Refactor common serviceclass validations (openshift#1858) 68f55c6 Catalog Controller should listen on https and serve metrics over TLS secured channel (openshift#1851) 5d0f773 Refactor common broker validations (openshift#1865) eeaf285 Add NamespacedServiceBroker switch to helm chart (openshift#1864) d2c960c Add NamespacedServiceBroker Feature (openshift#1863) ef15310 Fix NamespaceScoped doc text for ns types (openshift#1862) 8d0a637 fix async deprovision retry (openshift#1832) a918a16 Update registry code from serviceclass to clusterserviceclass (openshift#1852) 4dfd13c Bump dependency on go-open-service-broker-client to 0.0.6 (openshift#1856) 958b7cd Rename SharedServicePlanSpec to CommonServicePlanSpec (openshift#1850) 426aec3 pick a better random port to listen on in integration tests (openshift#1844) 6a59ada OrphanMitigation condition and different handling of retry timeout (openshift#1789) c9b8f60 Extracting common broker spec elements into embeddable struct (openshift#1841) 3f8fab6 Extract common service class spec fields (openshift#1834) 93dab13 Support for OSB [PR#452](openservicebrokerapi/servicebroker#452). (openshift#1849) 5e1e90d [WIP] Pass correct plan ID in deprovision request (for both deleting and orphan mitigation) (openshift#1847) 74f73c0 disable tests for deployment stage (openshift#1845) 82fc6e4 Revert "Pass correct plan ID in deprovision request (for both deleting and orphan mitigation) (openshift#1803)" (openshift#1843) 94b5795 gitignore integration.test binary (openshift#1840) 014c468 Extracting common plan spec into embeddable struct (openshift#1833) 5d7041b Use k8s NewUUID method exclusively (openshift#1836) eac3f96 A new test was added after prechecks happened for last pr. (openshift#1838) 4b5d159 Pass correct plan ID in deprovision request (for both deleting and orphan mitigation) (openshift#1803) cc02f0e [svcat] Adding a filter to get plan. (openshift#1758) 70afb56 reset RemovedFromBroker flag on plans that are re-added by broker (openshift#1824) 712dd4a Add behavior to print deleted instance name (openshift#1806) 55505be Update catalog charts README configuration (openshift#1823) 6426c98 Controller reconciliation rework - part 2 (ServiceBinding) (openshift#1819) c606560 Integrate svcat docs with Service Catalog's (openshift#1784) e9aeeb0 Synchronize some generated code that was missed along the way (openshift#1801) a63ebf7 Fix failing test: TestReconcileServiceInstanceWithFailedCondition (openshift#1813) 07ef743 Controller reconciliation rework - part 1 (ServiceInstance) (openshift#1779) a7d602b Export the touch instance command (openshift#1809) bddb9a7 Allow retries for instances with Failed condition after spec changes (openshift#1751) a777af5 Add enhanced parameter options to provision (openshift#1785) fd1a0b9 Print deleted bindings (openshift#1799) 36d437a Adding the ability to sync a service instance (openshift#1762) 1f60676 Remove Failed condition if there was no terminal failure (openshift#1788) cd831de allow brokers to respond to getCatalog() with no services (openshift#1772) (openshift#1781) e5c37ad Add ObservedGeneration and Provisioned into ServiceInstanceStatus (openshift#1748) 9021d8b Add carolynvs to OWNERS (openshift#1780) b7643d6 Add all-namespaces flag to svcat (openshift#1782) 01e652f Use docker to interact with files made by docker (openshift#1777) REVERT: c3e3071633 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 231772fcc00be08b6b2665a39c4a3bacb0b2271f

…service-catalog/' changes from c3e3071633..231772fcc0 231772fcc0 origin build: add origin tooling 98af5889bb v0.1.11 release changes 01e2f902d2 v0.1.10 release changes 49af94814f clear polling queue before starting new operation (#1855) 252958e5f8 Refactor common serviceclass validations (#1858) 68f55c62b5 Catalog Controller should listen on https and serve metrics over TLS secured channel (#1851) 5d0f77367d Refactor common broker validations (#1865) eeaf285f75 Add NamespacedServiceBroker switch to helm chart (#1864) d2c960c7b4 Add NamespacedServiceBroker Feature (#1863) ef15310d89 Fix NamespaceScoped doc text for ns types (#1862) 8d0a6374a6 fix async deprovision retry (#1832) a918a164f7 Update registry code from serviceclass to clusterserviceclass (#1852) 4dfd13c2b4 Bump dependency on go-open-service-broker-client to 0.0.6 (#1856) 958b7cd17f Rename SharedServicePlanSpec to CommonServicePlanSpec (#1850) 426aec37fb pick a better random port to listen on in integration tests (#1844) 6a59adaa2f OrphanMitigation condition and different handling of retry timeout (#1789) c9b8f60fd8 Extracting common broker spec elements into embeddable struct (#1841) 3f8fab6a8f Extract common service class spec fields (#1834) 93dab137fe Support for OSB [PR#452](openservicebrokerapi/servicebroker#452). (#1849) 5e1e90d2d6 [WIP] Pass correct plan ID in deprovision request (for both deleting and orphan mitigation) (#1847) 74f73c0b3e disable tests for deployment stage (#1845) 82fc6e4bf1 Revert "Pass correct plan ID in deprovision request (for both deleting and orphan mitigation) (#1803)" (#1843) 94b5795b98 gitignore integration.test binary (#1840) 014c46809c Extracting common plan spec into embeddable struct (#1833) 5d7041b0dd Use k8s NewUUID method exclusively (#1836) eac3f9610a A new test was added after prechecks happened for last pr. (#1838) 4b5d1591f1 Pass correct plan ID in deprovision request (for both deleting and orphan mitigation) (#1803) cc02f0ee67 [svcat] Adding a filter to get plan. (#1758) 70afb56e63 reset RemovedFromBroker flag on plans that are re-added by broker (#1824) 712dd4a925 Add behavior to print deleted instance name (#1806) 55505be865 Update catalog charts README configuration (#1823) 6426c9829d Controller reconciliation rework - part 2 (ServiceBinding) (#1819) c606560360 Integrate svcat docs with Service Catalog's (#1784) e9aeeb0acc Synchronize some generated code that was missed along the way (#1801) a63ebf74b0 Fix failing test: TestReconcileServiceInstanceWithFailedCondition (#1813) 07ef743192 Controller reconciliation rework - part 1 (ServiceInstance) (#1779) a7d602b9c6 Export the touch instance command (#1809) bddb9a78ed Allow retries for instances with Failed condition after spec changes (#1751) a777af55e6 Add enhanced parameter options to provision (#1785) fd1a0b90f6 Print deleted bindings (#1799) 36d437a8a8 Adding the ability to sync a service instance (#1762) 1f60676f20 Remove Failed condition if there was no terminal failure (#1788) cd831def6e allow brokers to respond to getCatalog() with no services (#1772) (#1781) e5c37ad3c7 Add ObservedGeneration and Provisioned into ServiceInstanceStatus (#1748) 9021d8b68b Add carolynvs to OWNERS (#1780) b7643d6e0f Add all-namespaces flag to svcat (#1782) 01e652ff75 Use docker to interact with files made by docker (#1777) REVERT: c3e3071633 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 231772fcc00be08b6b2665a39c4a3bacb0b2271f

mihnjong mentioned this pull request Feb 13, 2018

Relax the format of "CLI-friendly name" #442

Closed

duglin added the needs CLA label Feb 20, 2018

mihnjong closed this Feb 21, 2018

mihnjong reopened this Feb 21, 2018

chipchilders closed this Feb 21, 2018

chipchilders reopened this Feb 21, 2018

mihnjong closed this Feb 21, 2018

mihnjong reopened this Feb 21, 2018

duglin removed the needs CLA label Feb 22, 2018

subhankarc mentioned this pull request Feb 26, 2018

Catalog handling to filter plans/services in case of cross consumption cloudfoundry/service-fabrik-broker#207

Merged

Allow periods in the name field

ca470b6

Service class and plan names can contain periods (".").

duglin force-pushed the patch-2 branch from 0b0c122 to ca470b6 Compare March 12, 2018 23:31

duglin merged commit 5425a2b into openservicebrokerapi:master Mar 13, 2018

amshuman-kr pushed a commit to amshuman-kr/service-catalog that referenced this pull request Mar 15, 2018

Support for OSB PR kubernetes-retired#452 (openservicebrokerapi/servi…

58f841c

…cebroker#452).

This was referenced Mar 15, 2018

Support for OSB PR #452 to allow periods in the name field kubernetes-retired/service-catalog#1835

Closed

Support for OSB PR #452 amshuman-kr/service-catalog#1

Closed

amshuman-kr pushed a commit to amshuman-kr/service-catalog that referenced this pull request Mar 16, 2018

Support for OSB PR [kubernetes-retired#452](openservicebrokerapi/serv…

942e5ff

…icebroker#452).

amshuman-kr pushed a commit to amshuman-kr/service-catalog that referenced this pull request Mar 16, 2018

Support for OSB [PR#452](openservicebrokerapi/servicebroker#452).

27df35f

amshuman-kr pushed a commit to amshuman-kr/service-catalog that referenced this pull request Mar 16, 2018

Support for OSB [PR#452](openservicebrokerapi/servicebroker#452).

25ccad6

amshuman-kr pushed a commit to amshuman-kr/service-catalog that referenced this pull request Mar 19, 2018

Support for OSB [PR#452](openservicebrokerapi/servicebroker#452).

dade3fd

amshuman-kr mentioned this pull request Mar 19, 2018

Support for OSB PR #452 to allow periods in the name field kubernetes-retired/service-catalog#1849

Merged

duglin pushed a commit to kubernetes-retired/service-catalog that referenced this pull request Mar 19, 2018

Support for OSB [PR#452](openservicebrokerapi/servicebroker#452). (#1849

93dab13

)

teddyking mentioned this pull request Mar 13, 2020

Add support for OSBAPI 2.14 kubernetes-retired/go-open-service-broker-client#144

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow periods in the name field #452

Allow periods in the name field #452

mihnjong commented Feb 13, 2018 •

edited

Loading

cfdreddbot commented Feb 13, 2018

duglin commented Feb 20, 2018

mihnjong commented Feb 21, 2018

duglin commented Feb 21, 2018

chipchilders commented Feb 21, 2018

cfdreddbot commented Feb 21, 2018

mihnjong commented Feb 21, 2018

chipchilders commented Feb 21, 2018

chipchilders commented Feb 21, 2018

cfdreddbot commented Feb 21, 2018

chipchilders commented Feb 21, 2018

cfdreddbot commented Feb 21, 2018

n3wscott commented Feb 21, 2018 •

edited by avade

Loading

duglin commented Feb 22, 2018 •

edited by avade

Loading

duglin commented Feb 27, 2018

fmui commented Feb 27, 2018 •

edited by avade

Loading

mattmcneeney commented Feb 27, 2018 •

edited by avade

Loading

duglin commented Mar 6, 2018

subhankarc commented Mar 8, 2018

duglin commented Mar 8, 2018

duglin commented Mar 12, 2018

duglin commented Mar 13, 2018 •

edited by avade

Loading

n3wscott commented Mar 13, 2018 •

edited by avade

Loading

fmui commented Mar 13, 2018 •

edited by avade

Loading

vaikas commented Mar 13, 2018 •

edited by avade

Loading

mihnjong commented Mar 15, 2018

Allow periods in the name field #452

Allow periods in the name field #452

Conversation

mihnjong commented Feb 13, 2018 • edited Loading

cfdreddbot commented Feb 13, 2018

duglin commented Feb 20, 2018

mihnjong commented Feb 21, 2018

duglin commented Feb 21, 2018

chipchilders commented Feb 21, 2018

cfdreddbot commented Feb 21, 2018

mihnjong commented Feb 21, 2018

chipchilders commented Feb 21, 2018

chipchilders commented Feb 21, 2018

cfdreddbot commented Feb 21, 2018

chipchilders commented Feb 21, 2018

cfdreddbot commented Feb 21, 2018

n3wscott commented Feb 21, 2018 • edited by avade Loading

duglin commented Feb 22, 2018 • edited by avade Loading

duglin commented Feb 27, 2018

fmui commented Feb 27, 2018 • edited by avade Loading

mattmcneeney commented Feb 27, 2018 • edited by avade Loading

duglin commented Mar 6, 2018

subhankarc commented Mar 8, 2018

duglin commented Mar 8, 2018

duglin commented Mar 12, 2018

duglin commented Mar 13, 2018 • edited by avade Loading

n3wscott commented Mar 13, 2018 • edited by avade Loading

fmui commented Mar 13, 2018 • edited by avade Loading

vaikas commented Mar 13, 2018 • edited by avade Loading

mihnjong commented Mar 15, 2018

mihnjong commented Feb 13, 2018 •

edited

Loading

n3wscott commented Feb 21, 2018 •

edited by avade

Loading

duglin commented Feb 22, 2018 •

edited by avade

Loading

fmui commented Feb 27, 2018 •

edited by avade

Loading

mattmcneeney commented Feb 27, 2018 •

edited by avade

Loading

duglin commented Mar 13, 2018 •

edited by avade

Loading

n3wscott commented Mar 13, 2018 •

edited by avade

Loading

fmui commented Mar 13, 2018 •

edited by avade

Loading

vaikas commented Mar 13, 2018 •

edited by avade

Loading