-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax the format of "CLI-friendly name" #442
Comments
I think this proposal could also be applied to |
@leonwanghui what kind of "loosening" would you want to see on the "description" field? Its wide open now aside from it must be a non-empty string if present. @mihnjong would adding periods to the list of valid chars be sufficient? never mind I see you explicitly asked for . and _ I don't see an issue with that. Want to open a PR? |
@duglin What I mean is if there is some use cases to keep this filed required, because I didn't find any explanation in the spec. |
@leonwanghui I think its only required for Service and Plan in the /v2/catalog endpoint - which makes some sense since you probably what some kind of info there to help end users know which one to pick. Are you suggesting we make it optional in those spots too? Or are you just asking for some text in the spec to explain why its required? |
To me the second option is better, we should avoid any confusion in explanation of all required fields. |
@duglin Let me create a PR early next week. |
Not to break the compliance with k8s service catalog, we can follow the naming style at https://kubernetes.io/docs/concepts/overview/working-with-objects/names/
|
PR #452 is out for review. |
The spec says "As of now, the spec says "The CLI-friendly name of the plan. MUST only contain alphanumeric characters and hyphens (no spaces). MUST be unique within the service. MUST be a non-empty string.", which is too strict to express semantic versions in plan names.
For example, "v1.0.0." violates the rule. Can we make it relax a bit even before going to 3.0?
There're a few discussions before (#305 #154), but it would be great if we allow some special characters such as period and underscores.
The text was updated successfully, but these errors were encountered: