Code

Add Highlight In SQL#717

Code

Merged

penghuo merged 24 commits intoopensearch-project:mainopensearch-project/sql:mainfrom Bit-Quill:integ_highlight-in-sqlBit-Quill/opensearch-project-sql:integ_highlight-in-sqlCopy head branch name to clipboardAug 5, 2022

+657-11

Commits

Commits on Jul 26, 2022

• Add support for highlight to parser and AstExpressionBuilder

  Show description for 1097d9f
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  1097d9f

  Copy full SHA for 1097d9f

• Add unit test for highlight in AstExpressionBuilder

  Show description for 1a453e1
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  1a453e1

  Copy full SHA for 1a453e1

• Add unit test for highlight in AstBuilderTest

  Show description for 0d5c87b
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  0d5c87b

  Copy full SHA for 0d5c87b

• Support highlight as an Unresolved expression.

  Show description for 26d0b7e
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  26d0b7e

  Copy full SHA for 26d0b7e

• Represent highlight as UnresolvedExpression.

  Show description for 3f10b8b
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  3f10b8b

  Copy full SHA for 3f10b8b

• Support highlight in Analyzer.

  Show description for 543d0d7
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  543d0d7

  Copy full SHA for 543d0d7

• Treat highlight as a proper function in AST

  Show description for f47ffe7
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  f47ffe7

  Copy full SHA for f47ffe7

• Add support for highlight in Analyzer

  Show description for 5fdb939
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  5fdb939

  Copy full SHA for 5fdb939

• Add a simple IT test for highlight.

  Show description for 5c8db0a
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  5c8db0a

  Copy full SHA for 5c8db0a

• Register highlight function in the BuiltInFunctionRepository

  Show description for ac9f080
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  ac9f080

  Copy full SHA for ac9f080

• Partial support for highlight in physical plan.

  Show description for b526132
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  b526132

  Copy full SHA for b526132

• Add HighlightOperator.

  Show description for 807c475
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  807c475

  Copy full SHA for 807c475

• Highlight alpha complete.

  Show description for 74b6492
  

  MaxKsyunz

  authored and

  forestmvey

  committed
  74b6492

  Copy full SHA for 74b6492

• Initial implementation to upporting highlight('*')

  Show description for ad7affc
  forestmvey

  committed
  ad7affc

  Copy full SHA for ad7affc

Commits on Aug 1, 2022

• Add support for multiple highlight calls in select statement.

  Show description for bb97dde
  forestmvey

  committed
  bb97dde

  Copy full SHA for bb97dde

• Removed OpenSearchLogicalIndexScan highlightFields and dependencies. Improved test coverage and fixing checkstyle errors.

  Show description for 163b909
  forestmvey

  committed
  163b909

  Copy full SHA for 163b909

• Added HighlightExpressionTest

  Show description for b2a90d4
  forestmvey

  committed
  b2a90d4

  Copy full SHA for b2a90d4

• Added javadocs, minor PR revisions, and fixed jacoco errors by improving coverage for OpenSearchIndexScan

  Show description for 2c04c49
  forestmvey

  committed
  2c04c49

  Copy full SHA for 2c04c49

• Code cleanup, adding parsing failure tests, and adding tests for highlight acceptance as a string literal as well as qualified name.

  Show description for 01708e3
  forestmvey

  committed
  01708e3

  Copy full SHA for 01708e3

• Removing HighlightOperator functionality and unnecessary visitHighlight call in PhysicalPlanNodeVisitor..

  Show description for 6b96ac0
  forestmvey

  committed
  6b96ac0

  Copy full SHA for 6b96ac0

Commits on Aug 3, 2022

• Adding highlight function to functions.rst and removing unecessary function call in OpenSearchIndexScan.

  Show description for 232b19f
  forestmvey

  committed
  232b19f

  Copy full SHA for 232b19f

Commits on Aug 4, 2022

• Change highlight fields returned format to array list. Changed highlight all and wildcard to unsupported to open up output formatting changes for multiple returned highlight fields. Change tests fo…

  Show description for 9fbea30
  forestmvey

  committed
  9fbea30

  Copy full SHA for 9fbea30

• Fix bug where invalid schema name was being used for returned highlight fields

  Show description for 23a24e2
  forestmvey

  committed
  23a24e2

  Copy full SHA for 23a24e2

Commits on Aug 5, 2022

• Fix failing integration tests due to schema changes for highlight expression type.

  Show description for 449a330
  forestmvey

  committed
  449a330

  Copy full SHA for 449a330