Add Highlight In SQL #717
Merged
Add Highlight In SQL #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
In particular, highlightField is an expression now. Signed-off-by: MaxKsyunz <[email protected]>
HighlightFunction is converted to LogicalHighlight logical plan. Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
…Improved test coverage and fixing checkstyle errors. Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
…ing coverage for OpenSearchIndexScan Signed-off-by: forestmvey <[email protected]>
…light acceptance as a string literal as well as qualified name. Signed-off-by: forestmvey <[email protected]>
…ht call in PhysicalPlanNodeVisitor.. Signed-off-by: forestmvey <[email protected]>
dai-chen
reviewed
Aug 2, 2022
opensearch/src/main/java/org/opensearch/sql/opensearch/storage/OpenSearchIndexScan.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/HighlightExpression.java
Show resolved
Hide resolved
…nction call in OpenSearchIndexScan. Signed-off-by: forestmvey <[email protected]>
I added highlight to functions.rst under commit: 232b19f5924d2c46fd08b9d60abadb0d207ad016. Documentation website will be handled in a separate PR. |
…ght all and wildcard to unsupported to open up output formatting changes for multiple returned highlight fields. Change tests for updated coverage and disable highlight all and wildcard tests. Signed-off-by: forestmvey <[email protected]>
|
Under commit 9fbea3072bbf6cd3f89851a20344eecf720ac219 I have changed the output format to be more useable to the end user. See revisions to |
dai-chen
previously approved these changes
Aug 4, 2022
MaxKsyunz
requested changes
Aug 4, 2022
core/src/main/java/org/opensearch/sql/expression/HighlightExpression.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/HighlightExpression.java
Show resolved
Hide resolved
…ht fields Signed-off-by: forestmvey <[email protected]>
forestmvey
force-pushed
the
integ_highlight-in-sql
branch
from
d3af03b to
23a24e2
Compare
…ression type. Signed-off-by: forestmvey <[email protected]>
anirudha
approved these changes
Aug 5, 2022
dai-chen
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support highlighting function in SQL query engine.
Issues Resolved
Github Issue: 636
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.