Removes all ImmutableOpenMap references #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
DarshitChanpura
changed the title
|
CI issues will be resolved once a maven artifact is available with the latest ImmutableOpenMap change. I see that an artifact was pushed to https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/opensearch-core/3.0.0-SNAPSHOT/ but I'm not sure why the CI is still failing since we use sonatype as a repo for artifacts. |
cwperks
reviewed
Apr 27, 2023
| @@ -32,7 +33,7 @@ class GetSettingsResponseContainsIndicesMatcher extends TypeSafeDiagnosingMatche | |||
| @Override | |||
| protected boolean matchesSafely(GetSettingsResponse response, Description mismatchDescription) { | |||
|
|
|||
| final ImmutableOpenMap<String, Settings> indexToSettings = response.getIndexToSettings(); | |||
| final Map<String, Settings> indexToSettings = response.getIndexToSettings(); | |||
| for (String index : expectedIndices) { | |||
| if (!indexToSettings.containsKey(index)) { | |||
| mismatchDescription | |||
There was a problem hiding this comment.
Below this line I think you need to change the call from .keys() to .keySet()
There was a problem hiding this comment.
ahh..good catch!
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
removes-immutableOpenMap-reference
branch
from
626583a to
2ae6795
Compare
cwperks
approved these changes
Apr 27, 2023
RyanL1997
approved these changes
Apr 27, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2726 +/- ##
============================================
+ Coverage 61.47% 61.54% +0.06%
- Complexity 3397 3398 +1
============================================
Files 272 272
Lines 18740 18740
Branches 3284 3284
============================================
+ Hits 11521 11533 +12
+ Misses 5620 5610 -10
+ Partials 1599 1597 -2 |
stephen-crawford
approved these changes
Apr 28, 2023
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
) Signed-off-by: Darshit Chanpura <[email protected]>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Sam <[email protected]>
cwperks
pushed a commit
to cwperks/security
that referenced
this pull request
Jun 27, 2023
) Signed-off-by: Darshit Chanpura <[email protected]>
cwperks
added a commit
that referenced
this pull request
Jun 27, 2023
* Resolve ImmutableOpenMap issue from core refactor (#2715) * Switch from ImmutableOpenMap to Map in AliasExistsMatcher (#2725) * Remove references to ObjectObjectCursor Signed-off-by: Craig Perkins <[email protected]> * Switch from ImmutableOpenMap to Map in AliasExistsMatcher (#2725) * Remove references to ObjectObjectCursor Signed-off-by: Craig Perkins <[email protected]> * Removes a missed reference for ImmutableOpenMap (#2726) Signed-off-by: Darshit Chanpura <[email protected]> * Update ClusterInfoHolder Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Co-authored-by: Stephen Crawford <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continutation of #2715 #2725
Check List
- [ ] New functionality includes testing- [ ] New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.