Switch from ImmutableOpenMap to Map in AliasExistsMatcher #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
Signed-off-by: Craig Perkins <[email protected]>
cwperks
force-pushed
the
aliasmatcherfix
branch
from
a6bd872 to
a0c8923
Compare
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
peternied
reviewed
Apr 26, 2023
There was a problem hiding this comment.
Looks like there are 3 other places that could use this update, mind making these changes all at once? https://github.com/search?q=repo%3Aopensearch-project%2Fsecurity%20ObjectObjectCursor&type=code
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2725 +/- ##
============================================
- Coverage 61.48% 61.43% -0.06%
Complexity 3394 3394
============================================
Files 272 272
Lines 18743 18743
Branches 3285 3285
============================================
- Hits 11524 11514 -10
- Misses 5616 5626 +10
Partials 1603 1603 |
Signed-off-by: Craig Perkins <[email protected]>
peternied
previously approved these changes
Apr 26, 2023
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
stephen-crawford
previously approved these changes
Apr 26, 2023
Signed-off-by: Craig Perkins <[email protected]>
cwperks
commented
Apr 26, 2023
| for (String index : expectedIndices) { | ||
| if (!indexToSettings.containsKey(index)) { | ||
| mismatchDescription | ||
| .appendText("Response contains settings of indices: ") | ||
| .appendValue(indexToSettings.keySet()); | ||
| .appendValue(indexToSettings.keys()); |
There was a problem hiding this comment.
@scrawfor99 Sorry I had to push a small change and now CI is running again. I had this as keysIt when it really should be the key set here.
peternied
approved these changes
Apr 26, 2023
stephen-crawford
approved these changes
Apr 26, 2023
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Apr 27, 2023
…-project#2725) * Remove references to ObjectObjectCursor Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
1 task
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
…-project#2725) * Remove references to ObjectObjectCursor Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
…-project#2725) * Remove references to ObjectObjectCursor Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
…-project#2725) * Remove references to ObjectObjectCursor Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Sam <[email protected]>
cwperks
added a commit
to cwperks/security
that referenced
this pull request
Jun 27, 2023
…-project#2725) * Remove references to ObjectObjectCursor Signed-off-by: Craig Perkins <[email protected]>
cwperks
added a commit
to cwperks/security
that referenced
this pull request
Jun 27, 2023
…-project#2725) * Remove references to ObjectObjectCursor Signed-off-by: Craig Perkins <[email protected]>
cwperks
added a commit
that referenced
this pull request
Jun 27, 2023
* Resolve ImmutableOpenMap issue from core refactor (#2715) * Switch from ImmutableOpenMap to Map in AliasExistsMatcher (#2725) * Remove references to ObjectObjectCursor Signed-off-by: Craig Perkins <[email protected]> * Switch from ImmutableOpenMap to Map in AliasExistsMatcher (#2725) * Remove references to ObjectObjectCursor Signed-off-by: Craig Perkins <[email protected]> * Removes a missed reference for ImmutableOpenMap (#2726) Signed-off-by: Darshit Chanpura <[email protected]> * Update ClusterInfoHolder Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Co-authored-by: Stephen Crawford <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses comments raised here: #2715 (comment)
There is a compilation error in AliasExistsMatcher and this fixes the issue.
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.