Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution hint documentation added to cardinality agg #9224

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

asimmahmood1
Copy link

@asimmahmood1 asimmahmood1 commented Feb 17, 2025

Description

This PR adds documentation for execution_hint field that is being added for cardinality aggregator introduced in opensearch-project/OpenSearch#17312. Waiting for main repo PR to be merged.

This PR updates #8265

Issues Resolved

Closes #8264

Version

3.0

Frontend features

n/a

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws
Copy link
Collaborator

@asimmahmood1 FYI: There is another PR on this topic here #8265.

@asimmahmood1
Copy link
Author

@asimmahmood1 FYI: There is another PR on this topic here #8265.

Yes, I've kept that original commit and add mine on top. I wanted to make sure to provide the warning.

@kolchfa-aws
Copy link
Collaborator

Thanks! So should we close the original PR because this one contains the original commit?

@asimmahmood1
Copy link
Author

asimmahmood1 commented Feb 18, 2025

Thanks! So should we close the original PR because this one contains the original commit?

Yes, we can close the original PR. Note: I don't have permission to.

@kolchfa-aws
Copy link
Collaborator

@asimmahmood1 Is this PR ready for doc review?

@asimmahmood1
Copy link
Author

asimmahmood1 commented Feb 20, 2025

Code PR opensearch-project/OpenSearch#17312 has been merged, so this is ready for merge review.

Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws
Copy link
Collaborator

@asimmahmood1 Doc review complete. Moving this PR to editorial review. Is this still slated for 3.0, or is this going into 2.19.1?

@asimmahmood1
Copy link
Author

asimmahmood1 commented Feb 24, 2025

Thank you @kolchfa-aws . Its been merged into 2.19.1 as well, and 2.x PR is also open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Documentation change for Cardinality Aggregator: execution_hint field added
3 participants