-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce execution_hint
for Cardinality aggregation (#17312) - backport to 2.x
#17419
base: 2.x
Are you sure you want to change the base?
Introduce execution_hint
for Cardinality aggregation (#17312) - backport to 2.x
#17419
Conversation
…oject#17312) --------- Signed-off-by: Siddharth Rayabharam <[email protected]> Signed-off-by: Asim Mahmood <[email protected]> Signed-off-by: Asim M <[email protected]> Co-authored-by: Siddharth Rayabharam <[email protected]> Co-authored-by: Craig Perkins <[email protected]> (cherry picked from commit e3a6cca)
execution_hint
for Cardinality aggregation (#17312)execution_hint
for Cardinality aggregation (#17312) backport to 2.x
execution_hint
for Cardinality aggregation (#17312) backport to 2.xexecution_hint
for Cardinality aggregation (#17312) - backport to 2.x
❌ Gradle check result for 90a7bc8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Asim Mahmood <[email protected]>
Convert this back to draft until further notice. Thanks. |
❌ Gradle check result for a11eb0e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
.../src/main/java/org/opensearch/search/aggregations/metrics/CardinalityAggregationBuilder.java
Outdated
Show resolved
Hide resolved
* since 2.19 version has been merged: opensearch-project#17420 Signed-off-by: Asim Mahmood <[email protected]>
❌ Gradle check result for 668018b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #17419 +/- ##
============================================
+ Coverage 71.95% 71.98% +0.03%
- Complexity 65944 65967 +23
============================================
Files 5341 5341
Lines 307186 307210 +24
Branches 44830 44837 +7
============================================
+ Hits 221026 221156 +130
+ Misses 67703 67638 -65
+ Partials 18457 18416 -41 ☔ View full report in Codecov by Sentry. |
Description
[Describe what this change achieves]
Backport #17312 to 2.x
Backport to 2.19 is already done: https://github.com/opensearch-project/OpenSearch/pull/17420/files
Also need to backport the documentation opensearch-project/documentation-website#9224
Related Issues
Resolves #[16837]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.