Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce execution_hint for Cardinality aggregation (#17312) - backport to 2.x #17419

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from

Conversation

asimmahmood1
Copy link
Contributor

@asimmahmood1 asimmahmood1 commented Feb 21, 2025

Description

[Describe what this change achieves]
Backport #17312 to 2.x

Backport to 2.19 is already done: https://github.com/opensearch-project/OpenSearch/pull/17420/files

Also need to backport the documentation opensearch-project/documentation-website#9224

Related Issues

Resolves #[16837]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…oject#17312)

---------

Signed-off-by: Siddharth Rayabharam <[email protected]>
Signed-off-by: Asim Mahmood <[email protected]>
Signed-off-by: Asim M <[email protected]>
Co-authored-by: Siddharth Rayabharam <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
(cherry picked from commit e3a6cca)
@asimmahmood1 asimmahmood1 changed the title Introduce execution_hint for Cardinality aggregation (#17312) Introduce execution_hint for Cardinality aggregation (#17312) backport to 2.x Feb 21, 2025
@asimmahmood1 asimmahmood1 changed the title Introduce execution_hint for Cardinality aggregation (#17312) backport to 2.x Introduce execution_hint for Cardinality aggregation (#17312) - backport to 2.x Feb 21, 2025
Copy link
Contributor

❌ Gradle check result for 90a7bc8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Asim Mahmood <[email protected]>
@peterzhuamazon
Copy link
Member

Convert this back to draft until further notice.
To understand if it will break anything in 2.19.1.

Thanks.

@peterzhuamazon peterzhuamazon marked this pull request as draft February 21, 2025 21:04
Copy link
Contributor

❌ Gradle check result for a11eb0e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

* since 2.19 version has been merged:
  opensearch-project#17420

Signed-off-by: Asim Mahmood <[email protected]>
Copy link
Contributor

❌ Gradle check result for 668018b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 668018b: SUCCESS

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.98%. Comparing base (6a05e73) to head (668018b).
Report is 5 commits behind head on 2.x.

Files with missing lines Patch % Lines
...gations/metrics/CardinalityAggregationBuilder.java 66.66% 1 Missing and 4 partials ⚠️
...egations/metrics/CardinalityAggregatorFactory.java 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #17419      +/-   ##
============================================
+ Coverage     71.95%   71.98%   +0.03%     
- Complexity    65944    65967      +23     
============================================
  Files          5341     5341              
  Lines        307186   307210      +24     
  Branches      44830    44837       +7     
============================================
+ Hits         221026   221156     +130     
+ Misses        67703    67638      -65     
+ Partials      18457    18416      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants