Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix error handling while reading analyzer mapping rules. #5142

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 8, 2022

Description

Fix error handling while reading analyzer mapping rules.

Porting #5123 and #5141 to 2.x.
This ships in 2.4, so no CHANGELOG for 2.5.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

adnapibar and others added 2 commits November 8, 2022 14:47
Add new parseWordList method that takes a parser as a parameter. It reads custom rules from settings or a file, parses and handles errors. Make error messages less verbose for rules files outside config directory.

Signed-off-by: Rabi Panda <[email protected]>
@dblock dblock requested review from a team and reta as code owners November 8, 2022 14:51
@dblock dblock requested a review from Bukhtawar November 8, 2022 14:54
@dblock dblock changed the title Fix error handling while reading analyzer mapping rules. [Backport 2.x] Fix error handling while reading analyzer mapping rules. Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member Author

dblock commented Nov 8, 2022

Tests with failures:
 - org.opensearch.clustermanager.ClusterManagerTaskThrottlingIT.testTimeoutWhileThrottling

#5083

@dblock dblock requested a review from mch2 November 8, 2022 16:15
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock dblock merged commit 8363e46 into opensearch-project:2.x Nov 8, 2022
@dblock dblock deleted the 2.x-5123 branch November 8, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants