Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Raise error on malformed CSV #5141

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 8, 2022

Description

On top of #5139, raise error on malformed CSV.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Add new parseWordList method that takes a parser as a parameter. It reads custom rules from settings or a file, parses and handles errors. Make error messages less verbose for rules files outside config directory.

Signed-off-by: Rabi Panda <[email protected]>
@dblock dblock requested review from a team and reta as code owners November 8, 2022 14:15
@dblock dblock requested a review from adnapibar November 8, 2022 14:16
@dblock dblock changed the title Raise error on malformed CSV [Backport 2.4] Raise error on malformed CSV Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock dblock force-pushed the 2.4-5121-malformed-csv branch from 0fa5631 to 5b8a08a Compare November 8, 2022 14:25
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock dblock force-pushed the 2.4-5121-malformed-csv branch from 5b8a08a to de969d7 Compare November 8, 2022 14:35
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member Author

dblock commented Nov 8, 2022

Tests with failures:
 - org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue

#5031

Copy link
Member

@mch2 mch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants