Remove priviledged thread factory (fix integrated into latest Netty 4.1.118.Final) #17325
+6
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….1.118.Final) Signed-off-by: Andriy Redko <[email protected]>
reta
requested review from
peternied,
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
andrross
approved these changes
Feb 11, 2025
cwperks
approved these changes
Feb 11, 2025
|
Nice, just noticed netty/netty#14743. Thank you @reta! |
|
❌ Gradle check result for 9967add: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 9967add: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Feb 11, 2025
|
❌ Gradle check result for 9967add: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17325 +/- ##
============================================
- Coverage 72.47% 72.41% -0.07%
+ Complexity 65618 65566 -52
============================================
Files 5291 5291
Lines 304347 304329 -18
Branches 44182 44181 -1
============================================
- Hits 220578 220371 -207
- Misses 65670 65899 +229
+ Partials 18099 18059 -40 ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
….1.118.Final) (#17325) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit f40004a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
….1.118.Final) (#17325) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit f40004a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
….1.118.Final) (#17325) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit f40004a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Feb 11, 2025
….1.118.Final) (#17325) (#17328) (cherry picked from commit f40004a) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Feb 11, 2025
….1.118.Final) (#17325) (#17326) (cherry picked from commit f40004a) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Open
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove priviledged thread factory (fix integrated into latest Netty 4.1.118.Final)
Related Issues
Follow up on #17320
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.