-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump netty to 4.1.118.Final #17320
bump netty to 4.1.118.Final #17320
Conversation
777116c
to
2c8c5e2
Compare
please add the backport labels for 2.x, 2.19 and probably 2.19.0 (it'd be good if this would land in the 2.19.0 release as it's a CVE classified as "high" and now starts to pop up on all dependency scanners) the changelog verifier currently fails due to the missing backport labels |
❌ Gradle check result for 2c8c5e2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
this resolves CVE-2025-24970. Signed-off-by: Ralph Ursprung <[email protected]>
2c8c5e2
to
844975e
Compare
❌ Gradle check result for 844975e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY @rursprung!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17320 +/- ##
============================================
- Coverage 72.47% 72.36% -0.12%
+ Complexity 65618 65522 -96
============================================
Files 5291 5291
Lines 304347 304347
Branches 44182 44182
============================================
- Hits 220578 220227 -351
- Misses 65670 66031 +361
+ Partials 18099 18089 -10 ☔ View full report in Codecov by Sentry. |
this resolves CVE-2025-24970. Signed-off-by: Ralph Ursprung <[email protected]> (cherry picked from commit c82fffe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.19
# Create a new branch
git switch --create backport/backport-17320-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c82fffe8e333a8fff600dc22fa2e1aed7276d180
# Push it to GitHub
git push --set-upstream origin backport/backport-17320-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.19 Then, create a pull request where the |
this resolves CVE-2025-24970. Signed-off-by: Ralph Ursprung <[email protected]> (cherry picked from commit c82fffe)
Took a quick glance at GHSA-4g8c-wm8x-jfhw and I don't see any usages in the security repo of the affected code: |
this resolves CVE-2025-24970. Signed-off-by: Ralph Ursprung <[email protected]> (cherry picked from commit c82fffe)
* bump netty to 4.1.118.Final (#17320) this resolves CVE-2025-24970. Signed-off-by: Ralph Ursprung <[email protected]> (cherry picked from commit c82fffe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Run updateSHAs Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Ralph Ursprung <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Craig Perkins <[email protected]>
Description
this resolves CVE-2025-24970.
Related Issues
n/a
Check List
Functionality includes testing.API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.