Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to Spring Boot 3.2, and Virtual Threads if on Java 21 #446

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

SimonVerhoeven
Copy link
Contributor

What's changed?

A new recipe to enable VT in case the upgrade is for a Java 21 project.

What's your motivation?

To facilitate the adaptation of Virtual Threads

Anything in particular you'd like reviewers to focus on?

There's no org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_2 recipe yet, but I wanted to keep that for a standalone PR.

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Contributor

There's likely to be some conflicts with the PR I just created

We should indeed create a separate 3.2 migration recipe, and have that ready (and ideally documented) before next Thursday's release.

@SimonVerhoeven
Copy link
Contributor Author

Seems likely, I'll keep an eye on that one and update this one based on that one.

@SimonVerhoeven
Copy link
Contributor Author

The latest commit restores spring-boot-32.yml, and also adds the actual migration recipe.
This does mean it now also has a dependency on #447

@timtebeek timtebeek changed the title feat: add recipe for Spring Boot Java 21 related recipes feat: Upgrade to Spring Boot 3.2, and Virtual Threads if on Java 21 Nov 20, 2023
@timtebeek
Copy link
Contributor

Great work once again @SimonVerhoeven ! Thanks a lot for kicking off the Spring Boot 3.2 migration recipes & virtual thread adoption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants