Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate property migrations for META-INF/spring-configuration-metadata.json too #445

Merged
merged 11 commits into from
Nov 20, 2023

Conversation

timtebeek
Copy link
Contributor

What's changed?

  • Generate property migrations for META-INF/spring-configuration-metadata.json files too, not just the additional configuration properties.
  • Move the generated properties files to separate yaml files, to reduce duplication & incorrectly versioned properties, and make it easier to maintain going forward with a clear separation between what is generated and what is not.

What's your motivation?

We were missing out on generated replacements properties, based on DeprecatedConfigurationProperty annotated properties as per the Spring Boot docs on automatic metadata generation.

Any additional context

Before we only generated property migrations for three manually maintained additional configuration properties files:

@timtebeek timtebeek added bug Something isn't working recipe Recipe requested labels Nov 17, 2023
@timtebeek timtebeek self-assigned this Nov 17, 2023
@timtebeek
Copy link
Contributor Author

Now that we have neatly separated files we can also automate the changes going forward, similar to what we do for advisories: https://github.com/openrewrite/rewrite-java-dependencies/blob/main/.github/workflows/advisories.yml

@timtebeek timtebeek merged commit 8773433 into main Nov 20, 2023
@timtebeek timtebeek deleted the generated_metadata branch November 20, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-3.2 bug Something isn't working recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants