(fix) O3-3284: Use formatted patient display name throughout esm-patient-search-app #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xprl-gjf
changed the title
This was referenced May 17, 2024
|
Marking as draft, awaiting outcome of pull request openmrs/openmrs-esm-core#1003... |
xprl-gjf
changed the title
xprl-gjf
commented
May 23, 2024
packages/esm-patient-search-app/src/compact-patient-search/compact-patient-banner.component.tsx
Outdated
Show resolved
Hide resolved
|
@mogoodrich would you be able to review this along with the other O3-3284 PRs? (3 of them) |
mogoodrich
requested review from
denniskigen and
brandones
and removed request for
denniskigen
|
Deferred to others on this the service queues app, as I don't work with them as much, but I merged in the appointments change and triggered updating the other two PRs to branch off the new main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Despite the fact that a well-formatted patient display name is included in REST and FHIR responses, the patient search banner component was displaying a patient name with a hard-coded format.
Evident if using an alternative name format, e.g.
latinamerica, as per Wiki: Customizing Name LayoutsThe well-formatted patient display name is included as a
name.textattribute in FHIR responses, as per FM2-631, or as theuser.person.displayattribute in REST responses as per RESTWS-925.Screenshots
N/A
Related Issue
https://openmrs.atlassian.net/browse/O3-2115
Other
Similar fixes needed for some components in esm-patient-registration-app; esm-appointments-app esm-service-queues-app. To be delivered in separate PRs.