-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-3249: Introduce helper function to get well-formatted patient display name. #1003
Conversation
@ibacher I'd like to know if you think this is the correct place for this code, or should it be somewhere else such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xprl-gjf! A couple of notes:
- This isn't a refactor at all. It's adding a new function to the library, so it's a
(feat)
. - We prefer to have tickets versus just PRs (the description here is fine for a ticket).
- When adding a new file to one of the libraries, please include a
/** @category */
comment at the top. - Remember to actually run the commit scripts, particularly the documentation script.
PS Yes, it's perfectly acceptable to put something like this here. |
Wow, thank you @xprl-gjf! |
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
(No API changes made)
Summary
FHIR patient responses may now include a well-formatted display name as per FM2-631.
Despite this, there are many locations in the O3 frontend where a patient name is displayed explicitly as
${givenName} ${familyName}
.In going through the codebase to fix this, it becomes apparent that there is value in adopting a consistent approach to getting the patient display name.
Screenshots
N/A
Related Issue
https://openmrs.atlassian.net/browse/O3-3249
https://openmrs.atlassian.net/browse/O3-2115
Other
I already have open pull requests on openmrs-esm-patient-management:
I will pause those changes until this pull request is completed.